-
Notifications
You must be signed in to change notification settings - Fork 5.6k
refactor: migrate web Avatar to @makeplane/propel Avatar #9724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| /** | ||
| * Copyright (c) 2023-present Plane Software, Inc. and contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-only | ||
| * See the LICENSE file for details. | ||
| */ | ||
|
|
||
| import React from "react"; | ||
| // plane imports | ||
| import { Avatar } from "@makeplane/propel/components/avatar"; | ||
| import { AvatarGroup, type AvatarGroupSize } from "@makeplane/propel/components/avatar-group"; | ||
|
|
||
| type Props = { | ||
| children: React.ReactNode; | ||
| /** | ||
| * Shared size for every avatar in the stack. | ||
| */ | ||
| size: AvatarGroupSize; | ||
| /** | ||
| * The maximum number of avatars to display. If the number of children exceeds this value, the | ||
| * additional avatars are replaced by a count of the remaining avatars. | ||
| * @default 2 | ||
| */ | ||
| max?: number; | ||
| }; | ||
|
|
||
| /** | ||
| * An overlapping avatar stack that collapses the tail into a `+N` counter. | ||
| * | ||
| * Propel's `AvatarGroup` renders every child it is given, so the capping behaviour that | ||
| * `@plane/ui`'s `AvatarGroup` provided through `max` lives here as app chrome. The overflow | ||
| * indicator is a Propel `Avatar` with a `fallback`, matching the Avatar Group overflow pattern. | ||
| */ | ||
| export function AvatarGroupOverflow(props: Props) { | ||
| const { children, size, max = 2 } = props; | ||
|
|
||
| const avatars = React.Children.toArray(children); | ||
| const totalAvatars = avatars.length; | ||
| // If there is only one avatar past the limit, render it instead of a "+1" counter. | ||
| const maxAvatarsToRender = totalAvatars <= max + 1 ? max + 1 : max; | ||
| const overflowCount = totalAvatars - max; | ||
|
|
||
| return ( | ||
| <AvatarGroup size={size}> | ||
| {avatars.slice(0, maxAvatarsToRender)} | ||
| {maxAvatarsToRender < totalAvatars && ( | ||
| <Avatar alt={`${overflowCount} more members`} fallback={`+${overflowCount}`} /> | ||
| )} | ||
| </AvatarGroup> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Derive grouped-avatar state from resolved members.
Both components use raw ID-array lengths even when
getUserDetailsreturns no record. This produces misleading counts and empty groups.apps/web/core/components/cycles/list/cycle-list-item-action.tsx#L268-L268: filter resolved members and use that list for the tooltip count and avatar children.apps/web/core/components/project/card.tsx#L284-L284: use the filtered member list for the tooltip and theAvatarGroupOverflowconditional.📍 Affects 2 files
apps/web/core/components/cycles/list/cycle-list-item-action.tsx#L268-L268(this comment)apps/web/core/components/project/card.tsx#L284-L284🤖 Prompt for AI Agents