Assortment of code correctness fixes#551
Draft
azzyr wants to merge 9 commits into
Draft
Conversation
Main pain point with porting to newer C++ versions currently is the addition of the "concept" reserved keyword
These cause ambiguous overloads when C++20's rewritten and synthesized expressions come into play. Valve wrote these in the C++98/03 era... C++11/14 on modern compilers handles implicit casts fine The bool overload should probably be marked as explicit but I'd rather not mess with code using NULL over nullptr
C++20 mode MSVC enables /permissive- which strictly enforces name lookup rules for templates so we explicitly qualify them
More /permissive- cruft
more /permissive- cruft
This is wrong anyway.. /permissive-
This isn't a compile error but the warning shows up a lot in modern C++
azzyr
marked this pull request as draft
July 24, 2026 00:30
azzyr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly aimed towards Mapbase-derivative projects looking to migrate to modern C++ toolsets. Care is being taken to maintain compatibility with the original C++14 GCC/MSVC toolsets.
conceptreserved keyword in C++20 affects Response Rules code. Variable names using that keyword have been renamed across the boardDoes this PR close any issues?
PR Checklist
developbranch OR targets another branch with a specific goal in mind