Repository navigation
Conversation
lafrech
requested changes
Oct 16, 2026
lafrech
left a comment
lafrech
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks.
Just one minor comment.
| COMPONENT_SUBSECTIONS[self.openapi_version.major][k]: v | ||
| for k, v in self._subsections.items() | ||
| if v != {} | ||
| if v != {} and k in COMPONENT_SUBSECTIONS[self.openapi_version.major] |
Member
There was a problem hiding this comment.
I don' t think this is needed.
A KeyError is raised if user registers a request body with OpenAPI v2 since it is not supported (and therefore not in COMPONENT_SUBSECTIONS[self.openapi_version.major]). I belive this is fine. At least, this is what we've been doing with other components up till now.
Tests pass when removing this change.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #886
Description
In OpenAPI 3+, request bodies can be defined as reusable components under
#/components/requestBodies. This pull request adds full support for registering and resolvingrequestBodycomponents inapispec:request_bodytoCOMPONENT_SUBSECTIONS[3]asrequestBodies.request_bodycomponent registry and lazy registration buffer toComponents.Components.request_body(component_id, component, lazy=False, **kwargs).Components._resolve_refs_in_operationto resolverequestBodyreferences specified by component ID name to{"$ref": "#/components/requestBodies/<name>"}and safely inspectrequest_body.get("content", {}).request_body_helpertoBasePluginandMarshmallowPluginso Marshmallow schemas can be passed directly inside request body definitions.request_bodyregistration, chainability, duplicate naming, reference resolution, lazy loading, and Marshmallow plugin integration.