Repository navigation
Release the adapters and the debug plugin alongside 20.8 - #1718
Merged
Merged
Conversation
Dates the two adapter changelogs. The debug plugin's own convention is undated headings, so `## 16.2.0` is already release-ready. All three come from the same commit, #1697, and all three are about the `Sphere` collision shape that 20.8 adds: - `@melonjs/debug-plugin` 16.1.1 -> 16.2.0. The hitbox overlay draws a `Sphere`: a circle under a 2D camera, three great circles under a `Camera3d`, rather than the box containing it, whose corners stand 73% past the radius and read as a `Box3d` - `@melonjs/matter-adapter` 1.5.1 -> 1.5.2 and `@melonjs/planck-adapter` 1.6.1 -> 1.6.2. Refusing a shape the adapter cannot simulate now says why and what to use instead, naming the planar shape with the same footprint Peer ranges are deliberately unchanged at `>=19.8.0` and `>=20.0.0`. None of the three imports `Sphere`; each matches on the shape's type NAME, so on an engine without the shape the branch never runs and nothing fails to resolve. That is what lets the overlay keep working on older engines, which its own entry claims. Verified locally, since `publish.yml` builds plugins with `clean && build` and runs no tests for them: build, lint and suites green on all three, at 23, 226 and 221 tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NGvtaUNATVCVxD2qcbiY4t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dates the two adapter changelogs. The debug plugin's own convention is undated headings, so
## 16.2.0is already release-ready.All three come from the same commit, #1697, and all three are about the
Spherecollision shape that 20.8 adds.@melonjs/debug-pluginSphere: a circle under a 2D camera, three great circles under aCamera3d, rather than the box containing it, whose corners stand 73% past the radius and read as aBox3d@melonjs/matter-adapter@melonjs/planck-adapterPeer ranges are deliberately unchanged
>=19.8.0for the debug plugin and>=20.0.0for the adapters. None of the three importsSphere— each matches on the shape's type name, so on an engine without the shape the branch never runs and nothing fails to resolve. That is what lets the overlay keep working on older engines, which its own changelog entry claims.Verification
publish.ymlbuilds plugins withclean && buildand runs no tests for them, so these were run locally:Order
These should publish after 20.8.0. Every change here is about a shape that does not exist until 20.8 ships.
🤖 Generated with Claude Code
https://claude.ai/code/session_01NGvtaUNATVCVxD2qcbiY4t