Fix nRF52 RS232 bridge baud initialization#3018
Open
axhoff wants to merge 1 commit into
Open
Conversation
axhoff
marked this pull request as ready for review
July 21, 2026 16:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
begin(bridge_baud)pathThe pinned Adafruit nRF52 core ignores
begin()while aUartis already active. That can leave a bridge configured for 115200 baud running at an earlier component's baud rate. The active-state check is intentional: this core'send()does not guard an unopened UART, so calling it unconditionally is unsafe.The selected UART belongs exclusively to the bridge after initialization; configurations that would otherwise share it with GPS must disable GPS.
Validation
pio test -e native(13 tests passed)pio run -e RAK_4631_repeater_bridge_rs232_serial1pio run -e RAK_4631_repeater_bridge_rs232_serial2pio run -e Heltec_t114_without_display_repeater_bridge_rs232pio run -e ProMicro_repeater_bridge_rs232_serial1pio run -e Heltec_t096_repeater_bridge_rs232The reported RAK3401 configuration has no official PlatformIO RS232 environment in this repository; its register-level and end-to-end hardware validation is documented in the linked issue.
Fixes #3011