C++ plugin registration - #331
Conversation
I don't think we need a custom status code for this, it works without one in the C++ API of metatensor. (but this could also be thanks to the different treatment of |
We want to re-throw exceptions we saved at the C <=> C++ boundary
f782416 to
d668c74
Compare
|
I did a bit of refactoring here while splitting the changes into two separate commits, mainly making extra parameters Let me know if the changes are good for you, then we can merge! |
|
I can't self-approve, but your changes LGTM, thanks! |
Implement C++ plugin registration with the
MTA_REGISTER_CXX_PLUGINmacro.The code in 1de850a was suggested by Kimi-2.7-Code during a code review and implemented using Opus 5, so that a throwing C++ plugin's exception now reaches the caller with its original type (something I originally overlooked).
📚 Download documentation for this pull-request
⚙️ Download Python wheels for this pull-request (you can install these with pip)