fix: remove dead duplicate Running status check in start command - #290
Closed
mynk8 wants to merge 1 commit into
Closed
fix: remove dead duplicate Running status check in start command#290mynk8 wants to merge 1 commit into
mynk8 wants to merge 1 commit into
Conversation
mynk8
force-pushed
the
fix/duplicate-running-status-check
branch
from
May 5, 2026 13:33
37748a0 to
d96fe6d
Compare
The if-block above the switch was redundant with the case inside it. Consolidate into the switch statement only. Signed-off-by: mynk8 <mr.mayankgame@gmail.com>
mynk8
force-pushed
the
fix/duplicate-running-status-check
branch
from
May 5, 2026 13:35
d96fe6d to
6556d46
Compare
DivyanshuVortex
approved these changes
May 15, 2026
Contributor
|
Thanks — start.go was rewritten with container-state reconciliation, and the duplicated check no longer exists, so this is superseded. This can be closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
if instance.Status == "Running"check at line 50 already returns early, making the identicalcase "Running":inside the switch statement unreachable dead code.