fix(connectors): use json.Marshal in CreateTestResult to prevent injection and panics - #341
Closed
Harishrs2006 wants to merge 1 commit into
Closed
Conversation
…ction and panics Replace hand-rolled string concatenation in CreateTestResult with a typed struct and json.Marshal. The old approach embedded serviceID, testEndpoint, and secretName directly into a JSON string without escaping, allowing: - Malformed JSON when values contain quotes or backslashes - JSON field injection when values contain control characters Also replace three panic() calls with proper error returns, and add a safe checked type assertion for the response 'id' field. Fixes microcks#338 Signed-off-by: Harish R S <harishrs21082006@gmail.com>
This was referenced May 9, 2026
Contributor
|
Thanks for this! The typed-struct + json.Marshal approach (including validation of filteredOperations/headers/oauth sub-fields) landed on master, so this PR is superseded. The injection analysis in the description was on point. I suggest closing this |
Member
|
Thanks @Caesarsage, I'm clossing this PR as it's already tackled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-rolled string concatenation in
CreateTestResultwith a typed struct andjson.Marshal— special characters inserviceID,testEndpoint, andsecretNameare now safely escapedpanic()calls with propererrorreturnsidfield instead of bare.(string)that panics on unexpected server responseRelated issues: Fixes #340