Repository navigation
FIX: include extra_body_parameters in chat target identifiers - #3092
Merged
Richard Lundeen (richlundeen) merged 5 commits intoOct 12, 2026
Merged
Richard Lundeen (richlundeen) merged 5 commits into
Richard Lundeen (richlundeen) merged 5 commits into
Conversation
Richard Lundeen (richlundeen)
approved these changes
Oct 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 11, 2026
Contributor
Author
|
The one red job is a flaky timeout in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3091.
Adds
extra_body_parametersto the OpenAIChatTarget and LiteLLMChatTarget identifiers, matching what OpenAIResponseTarget already does. The audio config is merged into the extra body, so different voices get different identities too. Targets without an extra body getNone, which the identifier drops, so their hashes don't change.This doesn't touch the analytics/eval identity, since that only uses model, temperature and top_p.
Tests: different
reasoning_effortand audio voices give different hashes for both targets, and no extra body leaves it out. They fail on main. tests/unit/prompt_target, backend, memory, score, models and registry: 11205 passed (the 4 MCP/tool files needhttpx2, and the migration head test needsbuild_scripts, both missing locally and failing on main too).