fix(model): complete MiniMax optimizer role deployment, timeout forwarding, and typing - #255
Open
RohithPariki wants to merge 1 commit into
Open
Conversation
…rding, and typing
RohithPariki
marked this pull request as ready for review
August 26, 2026 01:35
Contributor
|
Thanks — the role-specific MiniMax routing and timeout forwarding are useful. One initialization blocker remains: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
skillopt.model.minimax_backendand the top-levelskillopt.modeldispatcher:chat_targetdropped thetimeoutparameter when routing tominimax_chat, ignoring caller-configured timeouts.chat_optimizer_messageswas not implemented inminimax_backend.py, forcing the dispatcher to fall back to_minimax.chat_target_messages(..., stage="optimizer")with mismatched target deployment resolution.set_optimizer_deploymentwas missing inminimax_backend.py, causingskillopt.model.set_optimizer_deployment()to omit MiniMax from optimizer deployment updates.minimax_backend.py(dict[int]) were malformed generics.Root Cause
MiniMax backend support previously focused on the target path, leaving optimizer role deployment registration, timeout forwarding, and structured message dispatcher entry points incomplete.
Solution
OPTIMIZER_DEPLOYMENTandset_optimizer_deploymenttoskillopt.model.minimax_backend.chat_optimizer_messagesinminimax_backend.pyusingOPTIMIZER_DEPLOYMENT.timeoutacrosschat_target,chat_optimizer, andchat_optimizer_messages.tuple[str, dict[str, int]]._minimax.set_optimizer_deploymentinskillopt.model.set_optimizer_deployment.tests/test_minimax_backend.pyvalidating deployment resolution, tool calls, and timeout propagation.Testing
pytest tests/test_minimax_backend.py(9/9 passed).ruff check(clean).Risk
Low. Additive and backwards-compatible with existing backend configuration.