Repository navigation
Document noUncheckedSideEffectImports fixes for CSS packages - #3694
Open
Martin Ferret (MartinFerret) wants to merge 2 commits into
Open
Martin Ferret (MartinFerret) wants to merge 2 commits into
Martin Ferret (MartinFerret) wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3607
Since TypeScript 6.0,
noUncheckedSideEffectImportsis on by default, soimport "library-name/css"fails with TS2882 when the subpath doesn't end in.cssand has no declaration file. A"*.css"wildcard declaration doesn't help, since it doesn't match the specifier.This PR updates the option's reference page:
.d.css.tsfile next to the stylesheet (users needallowArbitraryExtensions, otherwise TS6263), add a"types"condition in"exports"(no user setting needed), or expose a subpath ending in.css..d.ts, or set the option tofalsewhen a bundler already validates CSS imports.The
.d.css.tsapproach follows the discussion in microsoft/TypeScript#62674.The paragraph about the default behavior is left as is, since #3563 already updates it. The two PRs touch separate lines and merge without conflict in either order.
Every example was checked with TypeScript 6.0.3 and 7.0.2, with
moduleResolutionset tobundlerandnodenext.