Repository navigation
style(python): clarify unused arguments - #19113
Merged
Tobias Brick (tobiasb-ms) merged 2 commits intoOct 8, 2026
Merged
Tobias Brick (tobiasb-ms) merged 2 commits into
Tobias Brick (tobiasb-ms) merged 2 commits into
Conversation
Mark fixture-only dependencies explicitly, discard required callback parameters, and iterate mapping keys when values are unused. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the baseline suppressions for ARG001, ARG002, and B007 after resolving every existing finding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused cleanup preserves behavior, has reported validation, and has no unresolved findings.
0 open findings
What changed in this PR
Continues the focused Python lint cleanup by making unused arguments explicit without changing behavior.
Changes:
- Preserve fixture execution through
usefixtures. - Discard unused callback parameters and iterate mapping keys directly.
- Enable Ruff rules
ARG001,ARG002, andB007.
| File | Description |
|---|---|
scripts/repo/synthesize-repodata.py |
Remove unused loop value and discard callback parameter. |
scripts/ci/control-tower/tests/test_package_build.py |
Declare fixture-only dependency with usefixtures. |
ruff.toml |
Remove three baseline rule suppressions. |
base/images/tests/utils/pytest_plugin.py |
Explicitly discard unused hook parameter. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Tobias Brick (tobiasb-ms)
marked this pull request as ready for review
October 8, 2026 18:35
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Lynsey Rydberg (corvus-callidus)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mark fixture-only dependencies explicitly, discard required callback parameters, and iterate mapping keys directly when values are unused.
Remove the baseline suppressions for
ARG001,ARG002, andB007after resolving every existing finding. The cleanup and enforcement changes remain split into separate commits.This continues the focused Ruff cleanup following #19111.
Validation
pre-commit run --all-files