Repository navigation
refactor(python): simplify control flow - #19115
Merged
Tobias Brick (tobiasb-ms) merged 2 commits intoOct 8, 2026
Merged
Tobias Brick (tobiasb-ms) merged 2 commits into
Tobias Brick (tobiasb-ms) merged 2 commits into
Conversation
Collapse nested conditions, use existing iteration state directly, and replace equivalent branches while preserving behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the SIM102, SIM108, and SIM113 debt suppressions after resolving every existing finding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The refactors preserve existing behavior, and the newly enabled Ruff rules were comprehensively validated.
0 open findings
What changed in this PR
Simplifies equivalent Python control-flow patterns and enables additional Ruff checks.
Changes:
- Replaces nested conditionals and manual counters with simplified constructs.
- Removes global suppressions for
SIM102,SIM108, andSIM113.
| File | Description |
|---|---|
scripts/repo/synthesize-repodata.py |
Simplifies routing selection with a conditional expression. |
scripts/ci/render-specs-check/post_render_comment.py |
Uses enumerate for inline-diff counting. |
ruff.toml |
Enables three Ruff simplification rules. |
base/images/tests/utils/pytest_plugin.py |
Combines nested image-reference checks. |
base/images/tests/cases/static/test_efi.py |
Flattens nested EFI-entry conditions. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
Lynsey Rydberg (corvus-callidus)
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify equivalent control-flow patterns across the image-test plugin,
rendered-spec reporting, and repository metadata tooling.
Remove the baseline suppressions for
SIM102,SIM108, andSIM113afterresolving every existing finding. The cleanup and enforcement changes remain
split into separate commits.
This continues the focused Ruff rollout following #19114.
Validation
pre-commit run --all-files