fix(llm): preserve event loop in sync cache - #2479
Open
FU-max-boop wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Preserve caller-owned asyncio state in the synchronous LLM cache middleware. The middleware previously installed its private event loop as the thread default, then either left a closed loop installed after a cache miss or leaked the loop on an early cache-hit return.
Related Issues
Closes #2478.
Proposed Changes
finallyblock on cache hits, cache misses, and exceptions.Checklist
Validation
uv run poe checkuv run poe test_unit(317 passed)main.Additional Notes
The asynchronous cache middleware is unchanged because it already runs in the caller's active event loop and does not create or install a private loop.