Fix aten::mean dtype handling - #3010
Open
Promise Emmanuel Oluwadare (promiseeuler) wants to merge 1 commit into
Open
Fix aten::mean dtype handling#3010 Promise Emmanuel Oluwadare (promiseeuler) wants to merge 1 commit into
Promise Emmanuel Oluwadare (promiseeuler) wants to merge 1 commit into
Conversation
|
Promise Emmanuel Oluwadare (@promiseeuler) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While testing ONNXScript's TorchLib lowering for
torch.mean(..., dtype=...), I found that theaten::meanoverload ignored its schema'sdtypeargument and silently exported the wrong output type.This change:
dtypeargumentReduceMean, preserving the requested accumulation precisionFixes #3008.
Validation
torch.mean([1e8, 1, -1e8], dtype=torch.float64)Cast -> ReduceMean -> Squeezeruff checkpassedruff format --checkpassedThe focused e2e test file cannot collect on this local Python 3.14 build because
torchvisionimports the unavailable stdlib_lzmaextension; the same test logic was executed directly and passed.