fix(tsconfig): do not throw when "extends"/"references" cannot be resolved - #42005
Merged
Conversation
…olved We deliberately do not throw because we do not want to repeat the whole resolution process that tsc has: node_modules walk-up, package.json "exports" maps, directory-form project references. This reverts microsoft#41571, keeping its docs change. Fixes: microsoft#41989 Fixes: microsoft#41998
Contributor
Test results for "tests 1"7 flaky50724 passed, 1190 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 7807 passed, 1266 skipped Merge workflow run. |
Contributor
🟢 CI is clear — the one failure is a known pre-existing flakeHi, I'm the Playwright bot and I triaged the CI failures here. This PR only touches tsconfig DetailsOverall: 1 failure, on the MCP suite only; Pre-existing flake / infra
Recent final-verdict history for this test on Flaky (retried green, no action)
Triaged by the Playwright bot - agent run |
Pavel Feldman (pavelfeldman)
approved these changes
Jul 27, 2026
Dmitry Gozman (dgozman)
merged commit Jul 27, 2026
28ae3de
into
microsoft:main
49 of 50 checks passed
Dmitry Gozman (dgozman)
added a commit
that referenced
this pull request
Jul 28, 2026
…rences" cannot be resolved
Is this TODO tracked anywhere? Was about to open a ticket before I saw this — would like to subscribe to the issue, but couldn't find it |
1 task
Nils Reeh (NilsR0711)
added a commit
to NilsR0711/streamwall
that referenced
this pull request
Sep 2, 2026
Playwright reverted the hard failure on unresolved tsconfig `extends` paths in 1.62.1 (microsoft/playwright#42005, fixing #41989/#41998): an unresolved bare-specifier `extends` is silently ignored again instead of aborting spec collection, matching 1.61 behavior. The hoisted-package resolution gap itself is still open upstream (no node_modules walk-up), but it no longer breaks the E2E job. Verified locally: `tsc --noEmit` and the full `playwright test` suite (17/17) both pass against the hoisted @tsconfig/* bases. Drops the now-unnecessary @playwright/test ignore entry from dependabot.yml so future updates aren't skipped. Closes #691
Nils Reeh (NilsR0711)
added a commit
to NilsR0711/streamwall
that referenced
this pull request
Sep 2, 2026
Playwright reverted the hard failure on unresolved tsconfig `extends` paths in 1.62.1 (microsoft/playwright#42005, fixing #41989/#41998): an unresolved bare-specifier `extends` is silently ignored again instead of aborting spec collection, matching 1.61 behavior. The hoisted-package resolution gap itself is still open upstream (no node_modules walk-up), but it no longer breaks the E2E job. Verified locally: `tsc --noEmit` and the full `playwright test` suite (17/17) both pass against the hoisted @tsconfig/* bases. Drops the now-unnecessary @playwright/test ignore entry from dependabot.yml so future updates aren't skipped. Closes #691
Nils Reeh (NilsR0711)
added a commit
to NilsR0711/streamwall
that referenced
this pull request
Sep 2, 2026
Playwright reverted the hard failure on unresolved tsconfig `extends` paths in 1.62.1 (microsoft/playwright#42005, fixing #41989/#41998): an unresolved bare-specifier `extends` is silently ignored again instead of aborting spec collection, matching 1.61 behavior. The hoisted-package resolution gap itself is still open upstream (no node_modules walk-up), but it no longer breaks the E2E job. Verified locally: `tsc --noEmit` and the full `playwright test` suite (17/17) both pass against the hoisted @tsconfig/* bases. Drops the now-unnecessary @playwright/test ignore entry from dependabot.yml so future updates aren't skipped. Closes #691
Nils Reeh (NilsR0711)
added a commit
to NilsR0711/streamwall
that referenced
this pull request
Sep 2, 2026
Playwright reverted the hard failure on unresolved tsconfig `extends` paths in 1.62.1 (microsoft/playwright#42005, fixing #41989/#41998): an unresolved bare-specifier `extends` is silently ignored again instead of aborting spec collection, matching 1.61 behavior. The hoisted-package resolution gap itself is still open upstream (no node_modules walk-up), but it no longer breaks the E2E job. Verified locally: `tsc --noEmit` and the full `playwright test` suite (17/17) both pass against the hoisted @tsconfig/* bases. Drops the now-unnecessary @playwright/test ignore entry from dependabot.yml so future updates aren't skipped. Closes #691
Nils Reeh (NilsR0711)
added a commit
to NilsR0711/streamwall
that referenced
this pull request
Sep 2, 2026
Playwright reverted the hard failure on unresolved tsconfig `extends` paths in 1.62.1 (microsoft/playwright#42005, fixing #41989/#41998): an unresolved bare-specifier `extends` is silently ignored again instead of aborting spec collection, matching 1.61 behavior. The hoisted-package resolution gap itself is still open upstream (no node_modules walk-up), but it no longer breaks the E2E job. Verified locally: `tsc --noEmit` and the full `playwright test` suite (17/17) both pass against the hoisted @tsconfig/* bases. Drops the now-unnecessary @playwright/test ignore entry from dependabot.yml so future updates aren't skipped. Closes #691
Nils Reeh (NilsR0711)
added a commit
to NilsR0711/streamwall
that referenced
this pull request
Sep 2, 2026
* chore(deps): upgrade @playwright/test to 1.62.1 Playwright reverted the hard failure on unresolved tsconfig `extends` paths in 1.62.1 (microsoft/playwright#42005, fixing #41989/#41998): an unresolved bare-specifier `extends` is silently ignored again instead of aborting spec collection, matching 1.61 behavior. The hoisted-package resolution gap itself is still open upstream (no node_modules walk-up), but it no longer breaks the E2E job. Verified locally: `tsc --noEmit` and the full `playwright test` suite (17/17) both pass against the hoisted @tsconfig/* bases. Drops the now-unnecessary @playwright/test ignore entry from dependabot.yml so future updates aren't skipped. Closes #691 * test(dependabot): drop the stale @playwright/test ignore assertion The repo-invariant test added alongside the dependabot.yml group split asserted that the @playwright/test ignore entry stays in place. That entry is exactly what #691 removes now that the upstream tsconfig regression is gone, so assert the opposite: the entry must not linger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41989
Fixes #41998