fix(extension): do not treat orphaned preferences entries as an installed extension - #42224
Conversation
…lled extension Uninstalling the extension leaves orphaned entries in the profile's Preferences (an empty extensions.settings record, protection.macs.* and updateclientdata.apps.*) that matched the substring check and caused the wrong profile to be launched. Require a populated extensions.settings record instead. Fixes: microsoft/playwright-mcp#1712
Test results for "MCP"2 failed 8093 passed, 1304 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 Both failures are pre-existing Firefox flakes — the PR is clearThe two reds are MCP CLI tests on DetailsThis PR only changes Pre-existing flake / infra
Both are Firefox/Windows-only, in code the PR never touches, with a long history of the same failures elsewhere. No evidence points at this PR. Triaged by the Playwright bot - agent run |
c27d062
into
microsoft:main
## What's New ### New Tools - **`browser_start_recording` / `browser_stop_recording`** (opt-in via `--caps=devtools`) — Record actions that the user performs manually in the browser and return them as Playwright code. Useful when the user wants to demonstrate a flow instead of describing it ([#42359](microsoft/playwright#42359)) ## Bug Fixes - The default `--codegen` language is inferred from the environment ([#42150](microsoft/playwright#42150)) - Honor `--user-data-dir` in extension mode ([#42190](microsoft/playwright#42190)) - Do not treat orphaned browser preferences entries as an installed extension ([#42224](microsoft/playwright#42224)) - `browser_take_screenshot` returns the original screenshot bytes instead of silently downscaling them to model-specific limits ([#42406](microsoft/playwright#42406)) - Drop the cached browser backend after `browser_close` with a shared browser context, so subsequent tool calls from the same client no longer fail ([#42365](microsoft/playwright#42365)) - When connected to a remote endpoint, `browserInfo` reports the browser actually running remotely instead of the configured one ([#42228](microsoft/playwright#42228)) - Do not clobber the `chromiumSandbox` setting from the config file ([#42288](microsoft/playwright#42288)) - Do not run the heartbeat for HTTP clients that have not opened an event stream ([#42189](microsoft/playwright#42189)) - The internal `/killkillkill` endpoint is no longer registered outside of tests ([#42133](microsoft/playwright#42133))
2 participants
Summary
extensions.settings.<id>record,protection.macs.*,updateclientdata.apps.*) that matched the substring check, so the wrong profile could be launched.extensions.settings.<id>record instead; also readSecure Preferences, where the record lives on Windows/macOS.Fixes microsoft/playwright-mcp#1712