feat(trace): load trace files independently, produce a single context entry - #42350
Open
Dmitry Gozman (dgozman) wants to merge 1 commit into
Open
feat(trace): load trace files independently, produce a single context entry#42350Dmitry Gozman (dgozman) wants to merge 1 commit into
Dmitry Gozman (dgozman) wants to merge 1 commit into
Conversation
… entry TraceLoader now loads each .trace, .network and .stacks file into its own entry without matching them by the file name prefix, then merges everything into a single ContextEntry: per-file clock alignment, action merging by stepId, and origin-dependent metadata resolution all move from TraceModel to the loader. Network files derive their time origin from the first resource and reuse the format version learned from trace files. Stacks are applied through a global call id map.
Dmitry Gozman (dgozman)
force-pushed
the
trace-single-context-entry
branch
from
August 21, 2026 13:58
39310a7 to
0b1598b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"1 failed 8141 passed, 1361 skipped Merge workflow run. |
Contributor
Test results for "tests 1"7 flaky51277 passed, 1238 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a first look at the CI failures. 🟢 The one failure is a pre-existing flake — this PR is clear
DetailsAcross the two latest merged reports there's exactly one real failure; the "tests 1" run had only flaky results. This PR reworks trace file loading ( Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
Pavel Feldman (pavelfeldman)
left a comment
Pavel Feldman (pavelfeldman)
left a comment
Member
There was a problem hiding this comment.
I need additional context to understand / appreciate why this is needed.
| contextEntries.push(contextEntry); | ||
| } | ||
|
|
||
| for (const networkName of networkNames) { |
There was a problem hiding this comment.
I am expecting networkNames to always follow tracingNames after Devin's refactoring.
Pavel Feldman (pavelfeldman)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This prepares to being able to mix and match events from different contexts between trace files.
.trace,.networkand.stacksfile independently, without matching them by the file name prefix, and merges everything into a singleContextEntry.TraceModelto the loader.