Skip to content

test(webkit): reenable WebSocket handshake HAR coverage - #42513

Merged
Devin Rousso (dcrousso) merged 1 commit into
microsoft:mainfrom
dcrousso:fix-42205
Sep 2, 2026
Merged

test(webkit): reenable WebSocket handshake HAR coverage#42513
Devin Rousso (dcrousso) merged 1 commit into
microsoft:mainfrom
dcrousso:fix-42205

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

the upstream WebKit fix restores the reported WebSocket handshake headers on macOS 26

remove the platform skip so the existing HAR assertions run again

see #42205

the upstream WebKit fix restores the reported WebSocket handshake headers on macOS 26

remove the platform skip so the existing HAR assertions run again
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-library] › library/browsertype-connect.spec.ts:922 › run-server › socks proxy › should proxy ipv6 localhost requests Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/screencast.spec.ts:28 › screencast.start delivers frames via onFrame callback `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-event-request.spec.ts:181 › should return response body when Cross-Origin-Opener-Policy is set `@firefox-ubuntu-22.04-node20`

51308 passed, 1246 skipped


Merge workflow run.

@dcrousso
Devin Rousso (dcrousso) merged commit 8e11a5b into microsoft:main Sep 2, 2026
42 of 44 checks passed
@dcrousso
Devin Rousso (dcrousso) deleted the fix-42205 branch September 2, 2026 16:51
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/cli-save-as.spec.ts:48 › screenshot --filename @mcp-ubuntu-latest-chrome
❌ [firefox] › mcp/cli-core.spec.ts:97 › fill @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-core.spec.ts:115 › hover @mcp-windows-latest-firefox

8272 passed, 1371 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the failing CI here.

🟢 The failures are pre-existing MCP flakes — this PR is clear

This PR removes a single WebKit-only it.fixme in tests/library/har-websocket.spec.ts. The three red tests are all in the MCP CLI suite on Chromium and Firefox — nothing the diff can reach. Each one has a flake history on unrelated SHAs/PRs, so none of them is caused by this change.

Details

Overall assessment: the only failing check jobs were ubuntu-latest - chrome and windows-latest - firefox (MCP). All WebKit jobs — the only engine this PR touches — passed. The three flagged failures live in mcp/cli-core.spec.ts and mcp/cli-save-as.spec.ts, which don't exercise the WebSocket HAR path.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants