fix(azure): update DatastoreType import - #4181
Conversation
|
@microsoft-github-policy-service agree |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
|
Still active from my side. I rechecked that the PR is mergeable and the visible checks are green; happy to adjust if the DatastoreType compatibility import should follow a different preferred path. |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
|
Still active from my side. The visible checks are still green, and I am happy to rebase or adjust the compatibility import path if maintainers prefer a different approach. |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
|
Still active. I rechecked this against current Fresh validation on exact PR head
The PR remains mergeable, so no branch refresh appears necessary. Happy to adjust if maintainers prefer a different compatibility boundary. |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
|
Still active. The target branch is unchanged since the July 23 validation, the PR remains mergeable, and the visible checks are green. The two promptflow-azure call sites still need the compatibility import for current azure-ai-ml releases; happy to adjust if maintainers prefer a different boundary. |
|
Hi, thank you for your interest in helping to improve the prompt flow experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. |
|
Hi, thank you for your contribution. Since there has not been recent engagement, we are going to close this out. Feel free to reopen if you'd like to continue working on these changes. Please be sure to remove the |
Summary
DatastoreTypefrom the removedazure.ai.ml._restclient.v2022_10_01namespace.v2022_10_01_previewnamespace and falls back to the old namespace for older SDK layouts.Fixes #4176.
Verification
uv run --with azure-ai-ml==1.33.0 python - <<'PY' ...verified the compat module resolvesAzureBlob,AzureDataLakeGen2, andAzureFileunderazure-ai-ml==1.33.0.python3 -m py_compile src/promptflow-azure/promptflow/azure/_utils/_datastore_type.py src/promptflow-azure/promptflow/azure/operations/_artifact_utilities.py src/promptflow-azure/promptflow/azure/_storage/blob/client.py src/promptflow-azure/tests/sdk_cli_azure_test/unittests/test_blob_client.pyuvx black --check src/promptflow-azure/promptflow/azure/_utils/_datastore_type.py src/promptflow-azure/promptflow/azure/operations/_artifact_utilities.py src/promptflow-azure/promptflow/azure/_storage/blob/client.py src/promptflow-azure/tests/sdk_cli_azure_test/unittests/test_blob_client.pygit diff --checkI also tried the repository's
poetry install --with ci,testfromsrc/promptflow-azure, but dependency resolution did not complete locally after several minutes, so I kept local validation focused on the import compatibility path.