Repository navigation
[WIP] Fix failing GitHub Actions job Typecheck - #11694
Closed
Bill Schnurr (bschnurr) with Copilot wants to merge 6 commits into
Closed
Bill Schnurr (bschnurr) with Copilot wants to merge 6 commits into
Bill Schnurr (bschnurr) with Copilot wants to merge 6 commits into
Conversation
…er and call shape
…tdefault, validate non-string key subtypes, propagate isTypeIncomplete
…ng test collision with existing TypedDict28/29 Co-authored-by: bschnurr <1946977+bschnurr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main(via Expand conditional TypedDict test coverage #11617) both independently added a test namedTypedDict28(using the same sample filenametypedDict28.py). GitHub's ephemeral PR test-merge commit silently combined the two additions into a singletest('TypedDict28', ...)body instead of flagging a conflict, producing twoconst analysisResults/const configOptionsdeclarations in the same scope (TS2451tscerrors) and clobberingtypedDict28.py's content.typedDict28.py/TypedDict28test (andtypedDict29.py/TypedDict29) to the originalmain(Expand conditional TypedDict test coverage #11617) conditional-TypedDict-coverage content.typedDict30.pyand registered it as a newTypedDict30test.getTypedDictClassFromMethod,applyTypedDictMethodTransformintypedDicts.ts, and its integration intypeEvaluator.ts).tsc --noEmit(viapnpm exec lerna exec -- "tsc --noEmit") now passes with no errors.typeEvaluator7.test.ts(171 tests) andchecker.test.ts/typedDicts tests (72 tests) pass.