Skip to content

Replace branch deletion picker with a modal dialog - #8947

Merged
Alex Ross (alexr00) merged 5 commits into
mainfrom
copilot/better-ux-branch-delete-options
Sep 11, 2026
Merged

Replace branch deletion picker with a modal dialog#8947
Alex Ross (alexr00) merged 5 commits into
mainfrom
copilot/better-ux-branch-delete-options

Conversation

Copilot AI commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Branch deletion uses a searchable multi-select picker for a small set of cleanup actions. Replace it with the requested modal dialog and concise buttons.

  • Dialog: Show available actions as buttons; move branch names, repository details, and worktree paths into the detail text.
  • Combined cleanup: Add “Delete All” when multiple deletion actions are available. Keep Codespace suspension separate.
  • Behavior: Preserve cancellation and action-availability safeguards. Leave automatic cleanup unchanged and clarify the preference descriptions.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Copilot AI changed the title [WIP] Update delete options to use modal dialog Replace branch deletion picker with a modal dialog Sep 10, 2026
@alexr00
Alex Ross (alexr00) marked this pull request as ready for review September 11, 2026 08:33
Copilot AI lite review requested due to automatic review settings September 11, 2026 08:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed changes preserve safeguards and include updated test coverage.

Pull request overview

Replaces the branch-deletion picker with a modal action dialog while preserving cleanup safeguards.

Changes:

  • Adds concise cleanup actions, details, and “Delete All” handling.
  • Updates deletion replies and state propagation.
  • Clarifies preferences and expands coverage.
File summaries
File Summary
webviews/common/context.tsx Handles deletion replies and state updates.
src/test/github/pullRequestOverview.test.ts Tests modal and reply behavior.
src/test/github/folderRepositoryManager.test.ts Tests cleanup action combinations and safeguards.
src/github/pullRequestReviewCommon.ts Implements modal cleanup actions.
src/github/pullRequestOverview.ts Replies with deletion results and refreshes the panel.
src/github/activityBarViewProvider.ts Uses reply-based deletion handling.
package.nls.json Clarifies cleanup preference descriptions.
Review details
  • Files reviewed: 7/7 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@alexr00
Alex Ross (alexr00) merged commit 2f06150 into main Sep 11, 2026
7 checks passed
@alexr00
Alex Ross (alexr00) deleted the copilot/better-ux-branch-delete-options branch September 11, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better UX for choosing branch delete options

4 participants