chore: bump windows-process-tree to 0.8.0 to fix UTF-8 command lines in Process Explorer#324283
chore: bump windows-process-tree to 0.8.0 to fix UTF-8 command lines in Process Explorer#324283arham766 wants to merge 1 commit into
Conversation
Picks up microsoft/vscode-windows-process-tree#87, which fixes process command lines being converted with CP_ACP instead of CP_UTF8, so non-ANSI characters (e.g. Cyrillic) rendered as ? in the Process Explorer. Fixes microsoft#219183
There was a problem hiding this comment.
Pull request overview
This PR bumps @vscode/windows-process-tree from ^0.7.0 to ^0.8.0 to fix Process Explorer rendering non-ANSI (e.g. Cyrillic) process command lines as ?. The root cause was fixed upstream by switching WideCharToMultiByte from CP_ACP to CP_UTF8. The module feeds ProcessItem.cmd in src/vs/base/node/ps.ts, which is displayed in the Process Explorer hover, so the bump directly resolves issue #219183. The 0.8.0 release is additive over 0.7.0, so no source changes are needed.
Changes:
- Bumped
@vscode/windows-process-treeto^0.8.0in bothpackage.jsonandremote/package.json. - Regenerated both lockfiles to resolve
0.8.0(consistent version, integrity hash, and unchangednode-addon-api@7.1.0transitive dep). - Incidentally dropped the empty
ssh2/node_modules/cpu-featuresplaceholder from both lockfiles (npm 11 format change; thessh2 → cpu-features: "0.0.0"override is retained).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Bumps desktop dependency to ^0.8.0. |
| package-lock.json | Resolves 0.8.0 with new integrity hash; removes stale cpu-features placeholder entry. |
| remote/package.json | Bumps remote dependency to ^0.8.0. |
| remote/package-lock.json | Resolves 0.8.0 with matching integrity hash; removes stale cpu-features placeholder entry. |
Files not reviewed (1)
- remote/package-lock.json: Generated file
@microsoft-github-policy-service agree |
Fixes #219183
The root cause was fixed upstream in
@vscode/windows-process-tree0.8.0: microsoft/vscode-windows-process-tree#87 changed theWideCharToMultiBytecalls inprocess_commandline.ccfromCP_ACPtoCP_UTF8, so process command lines containing non-ANSI characters no longer collapse to?. VS Code still resolved 0.7.0, which is why the Process Explorer kept showing question marks.This bumps
@vscode/windows-process-treeto^0.8.0inpackage.jsonandremote/package.json, with lockfiles regenerated by npm 11.Verified on Windows 11 by loading both module versions against a process spawned with Cyrillic in its command line:
0.8.0 is otherwise additive over 0.7.0 (a new
getAllProcessesAPI and CI/build maintenance).