Skip to content

chore: bump windows-process-tree to 0.8.0 to fix UTF-8 command lines in Process Explorer#324283

Open
arham766 wants to merge 1 commit into
microsoft:mainfrom
arham766:fix/windows-process-tree-unicode
Open

chore: bump windows-process-tree to 0.8.0 to fix UTF-8 command lines in Process Explorer#324283
arham766 wants to merge 1 commit into
microsoft:mainfrom
arham766:fix/windows-process-tree-unicode

Conversation

@arham766

@arham766 arham766 commented Jul 4, 2026

Copy link
Copy Markdown

Fixes #219183

The root cause was fixed upstream in @vscode/windows-process-tree 0.8.0: microsoft/vscode-windows-process-tree#87 changed the WideCharToMultiByte calls in process_commandline.cc from CP_ACP to CP_UTF8, so process command lines containing non-ANSI characters no longer collapse to ?. VS Code still resolved 0.7.0, which is why the Process Explorer kept showing question marks.

This bumps @vscode/windows-process-tree to ^0.8.0 in package.json and remote/package.json, with lockfiles regenerated by npm 11.

Verified on Windows 11 by loading both module versions against a process spawned with Cyrillic in its command line:

0.7.0:  "C:\Program Files
odejs
ode.exe" -e "setTimeout(()=>{}, 20000)" -- ??????-???-?????????
0.8.0:  "C:\Program Files
odejs
ode.exe" -e "setTimeout(()=>{}, 20000)" -- Привет-мир-Кириллица

0.8.0 is otherwise additive over 0.7.0 (a new getAllProcesses API and CI/build maintenance).

Picks up microsoft/vscode-windows-process-tree#87, which fixes
process command lines being converted with CP_ACP instead of CP_UTF8,
so non-ANSI characters (e.g. Cyrillic) rendered as ? in the Process
Explorer.

Fixes microsoft#219183
Copilot AI review requested due to automatic review settings July 4, 2026 04:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps @vscode/windows-process-tree from ^0.7.0 to ^0.8.0 to fix Process Explorer rendering non-ANSI (e.g. Cyrillic) process command lines as ?. The root cause was fixed upstream by switching WideCharToMultiByte from CP_ACP to CP_UTF8. The module feeds ProcessItem.cmd in src/vs/base/node/ps.ts, which is displayed in the Process Explorer hover, so the bump directly resolves issue #219183. The 0.8.0 release is additive over 0.7.0, so no source changes are needed.

Changes:

  • Bumped @vscode/windows-process-tree to ^0.8.0 in both package.json and remote/package.json.
  • Regenerated both lockfiles to resolve 0.8.0 (consistent version, integrity hash, and unchanged node-addon-api@7.1.0 transitive dep).
  • Incidentally dropped the empty ssh2/node_modules/cpu-features placeholder from both lockfiles (npm 11 format change; the ssh2 → cpu-features: "0.0.0" override is retained).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Bumps desktop dependency to ^0.8.0.
package-lock.json Resolves 0.8.0 with new integrity hash; removes stale cpu-features placeholder entry.
remote/package.json Bumps remote dependency to ^0.8.0.
remote/package-lock.json Resolves 0.8.0 with matching integrity hash; removes stale cpu-features placeholder entry.
Files not reviewed (1)
  • remote/package-lock.json: Generated file

@arham766

arham766 commented Jul 4, 2026

Copy link
Copy Markdown
Author

@arham766 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: In process explorer if user has UTF-8 / cyrrilic symbols in name it will be displayed by non displayable symbols ("question mark" symbol)

3 participants