Conversation
The vendored terminal-notifier 1.7.2 is an x86_64-only binary. On Apple silicon it needs Rosetta, and on macOS 27 Intel binaries no longer run at all, so node-notifier fails on every build that uses webpack-notifier, gulp-notify and friends. Fixes mikaelbr#361, supersedes mikaelbr#441. terminal-notifier 3.x (julienXX/terminal-notifier, released August 2026) ships an official universal x86_64 + arm64 bundle built on Apple's UserNotifications framework. This commit vendors that release unchanged. Supply chain: the bundle is the upstream GitHub release asset terminal-notifier-3.1.0.zip, SHA-256 e969d4ae20287da1ba55495ae31dcedd8e9069deb8ce4eed24f6561a5fc3e4d5. scripts/update-terminal-notifier.sh downloads it, verifies that checksum and unpacks it into vendor/mac.noindex, so anyone can reproduce and audit what is committed. `codesign --verify --strict` passes on the bundle. Code changes needed for terminal-notifier 3: - Minimum macOS for native notifications is 10.14 (Darwin 18); utils.isMojaveOrLater() replaces isMountainLion() (kept as alias). - Responses are plain text instead of -json: the clicked action title, the typed reply, or @timeout / @closed / @ACTIONCLICKED. They are mapped back onto the existing { activationType, activationValue } shape, so callbacks and the click/replied/timeout events keep working. JSON output from older binaries used via customPath is still accepted. - Exit code 6 (timeout) is reported as a timeout, not an error. - -action is read from argv, one flag per button, unquoted; -reply may stand alone or take a placeholder string. - -appIcon and -sender are gone (the framework always uses the sending bundle's identity); they are dropped instead of producing stderr noise. - UNUserNotificationCenter refuses to request permission for a bundle LaunchServices has never seen, which is the case for an app inside node_modules. On that specific error the bundle is registered with lsregister once and the notification retried. Tested on macOS 27.0 arm64 without Rosetta (plain notification, action buttons with timeout, reply with placeholder) and with the jest suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored terminal-notifier 1.7.2 is an x86_64-only binary. On Apple silicon it needs Rosetta, and on macOS 27 Intel binaries no longer run at all, so node-notifier fails on every build that uses webpack-notifier, gulp-notify and friends. Fixes #361, supersedes #441.
terminal-notifier 3.x (julienXX/terminal-notifier, released August 2026) ships an official universal x86_64 + arm64 bundle built on Apple's UserNotifications framework. This commit vendors that release unchanged.
Supply chain: the bundle is the upstream GitHub release asset terminal-notifier-3.1.0.zip, SHA-256
e969d4ae20287da1ba55495ae31dcedd8e9069deb8ce4eed24f6561a5fc3e4d5. scripts/update-terminal-notifier.sh downloads it, verifies that checksum and unpacks it into vendor/mac.noindex, so anyone can reproduce and audit what is committed.
codesign --verify --strictpasses on the bundle.Code changes needed for terminal-notifier 3:
Tested on macOS 27.0 arm64 without Rosetta (plain notification, action buttons with timeout, reply with placeholder) and with the jest suite.