RFC-0008: Add icons as MLflow-managed presentation metadata - #45
Merged
Merged
Conversation
…lugin The UI needs icons on skill and plugin cards, and neither upstream format can supply them: the Agent Skills frontmatter and the Agent Plugins plugin.schema.json define no icon field. Icons are therefore purely MLflow-managed parent-level presentation metadata, following RFC-0004's MCP Server Registry pattern (a mutable icons list on the parent entity, returned exactly as stored) minus its payload fallback, which has no equivalent here; the UI shows a default glyph when unset. The RegistryIcon shape (src, sizes, mimeType, theme) deliberately matches RFC-0004's MCPIcon so UIs share one icon renderer across registries. Icons ride the existing create/update surfaces (create_skill, update_skill, and the agent plugin equivalents) and are never settable through register_skill, matching the established parent-metadata rule. Schema impact is one nullable JSON column per parent table, with no new indexes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jwm4
marked this pull request as ready for review
September 1, 2026 21:35
mprahl
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Amends RFC-0008 to add an
iconsfield to theSkillandAgentPluginparent entities: a mutable, MLflow-managed list of icon descriptors, returned exactly as stored, settable throughcreate_skill/update_skilland the agent plugin equivalents (not throughregister_skill, matching the existing parent-metadata rule). TheRegistryIconshape (src, optionalsizes/mimeType/theme) deliberately matches RFC-0004'sMCPIconso UIs can share one icon renderer across the MCP, skill, and agent plugin registries. Schema impact is one nullable JSON column per parent table, no new indexes.Why
The registry UI wants icons on skill and plugin cards, and neither upstream format can provide them: the Agent Skills frontmatter defines no icon field (its
metadatamap is string-to-string), and the Agent Pluginsplugin.schema.jsondefinesname/version/description/author/homepage/repository/license/keywords/extensionsand nothing visual. So unlike RFC-0004, there is no payload fallback to specify: icons are purely MLflow-managed, and the UI shows its default glyph when unset. This follows the MCP Server Registry's mutable presentation-metadata pattern, minus the fallback half that has no equivalent here.Deliberately not included:
display_name. That field was dropped during the original review (see this thread) with the position that it can be added later if real user demand appears; none has, so it stays out.Stacking note
This PR is stacked on #44, so two commits show until #44 merges; only
Add icons as MLflow-managed presentation metadatais in scope here.Authored by Bill Murdock with assistance from Claude Code.
🤖 Generated with Claude Code