Skip to content

perf: optimize getSlots #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpatiny merged 1 commit into from
Sep 3, 2026
Merged

perf: optimize getSlots #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions src/xyArray/utils/getSlots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,7 @@ export function getSlots(
const { delta = 1 } = options;
const deltaIsFunction = typeof delta === 'function';

const possibleXs = Float64Array.from(
data.flatMap((spectrum) => spectrum.x as number[]),
);
possibleXs.sort();
const possibleXs = sortedXs(data);

if (possibleXs.length === 0) {
throw new Error('can not process empty arrays');
Expand Down Expand Up @@ -65,3 +62,24 @@ export function getSlots(
}
return slots;
}

/**
* Fast way of combining array using typed array and set
* @param data - The spectra.
* @returns Their x values, ascending.
*/
function sortedXs(data: DataXY[]): Float64Array {
let total = 0;
for (const spectrum of data) {
total += spectrum.x.length;
}

const possibleXs = new Float64Array(total);
let at = 0;
for (const spectrum of data) {
possibleXs.set(spectrum.x, at);
at += spectrum.x.length;
}
possibleXs.sort();
return possibleXs;
}
Loading