fix(tier-check): count an SDK release in the 24h before a spec release as tracking it - #458
Merged
felixweinberger merged 1 commit intoAug 17, 2026
Conversation
commit: |
…e as tracking it Lockstep SDKs publish in the hours before the spec release is tagged (for 2026-07-28: python-sdk 3h early, go-sdk 3.5h, typescript-sdk the evening before), so "first SDK release at or after the spec" read them as not having released and would fail them 30 days later. Allow a 24h lead.
maxisbey
force-pushed
the
fix/tier-check-spec-tracking-window
branch
from
August 16, 2026 12:45
b1f6f02 to
dafbaa8
Compare
maxisbey
changed the title
maxisbey
marked this pull request as ready for review
August 16, 2026 12:51
felixweinberger
approved these changes
Aug 17, 2026
felixweinberger
requested changes
Aug 17, 2026
felixweinberger
approved these changes
Aug 17, 2026
Contributor
Author
|
Closing in favour of tracking the problem as an issue: #459. |
Contributor
Author
|
Reopening: this is the fix for #459. |
felixweinberger
approved these changes
Aug 17, 2026
felixweinberger
enabled auto-merge (squash)
August 17, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #459.
tier-check's spec-tracking check looks for the first SDK release at or after the latest spec release. SDKs that ship in lockstep publish in the hours before the spec tag, so the check reads them as "no release for this spec yet" and flips tofail(a Tier 1 blocker) 30 days later unless they happen to release again. This allows a 24h lead.For the 2026-07-28 spec (tagged 16:47Z): python-sdk v2.0.0 went out at 13:41Z, go-sdk v1.7.0 at 13:09Z, typescript-sdk's 2.0.0 packages the evening before — all three currently show
19d gapand would turnfailon 2026-08-28; with this change they pass at 0d/−1d. csharp-sdk (21:27Z, after the tag) is unchanged, and java-sdk (nothing since June) still fails on day 31 as it should.Replaying the rule over every stable spec release × ten SDKs (70 pairs): 56 identical, 14 change, none from pass to fail. The pattern predates this cycle — typescript-sdk 1.23.0 was published 3 minutes before the 2025-11-25 tag, and kotlin-sdk 0.4.0 shipped the morning of 2025-03-26 yet was scored as a 35-day fail against that spec.
Noticed but left alone (pre-existing, separate if wanted): SDK releases are read with
per_page: 50, which typescript-sdk's per-package releases (159 so far) will eventually outrun; and pre-releases count as SDK releases.