refactor!: keep streamable http state in its transport - #1205
Draft
nickcoai wants to merge 2 commits into
Draft
Conversation
Move cancellation registration, control sends, and session generation into the streamable http transport wrapper. Restore the generic worker queue and keep the existing scheduling and cancellation behavior. Cover construction paths, queue admission, and stream ownership. Document the worker-to-transport migration. BREAKING CHANGE: StreamableHttpClientTransport is no longer a WorkerTransport alias, and StreamableHttpClientWorker no longer implements Worker. Use StreamableHttpClientTransport::spawn or spawn_with_ct for worker construction.
github-actions
Bot
added
T-documentation
This was referenced Aug 23, 2026
Reuse the cancellation lookup and existing test client. Remove duplicate migration guidance and overlapping constructor checks, and shorten new comments. Keep the cancellation and stream lifetime behavior unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on oxcabe's worker ownership review in #1186.
This draft is based on #1186, so its diff contains only the refactor and its tests.
StreamableHttpClientTransport.WorkerTransport.Validation
Passed locally:
justfile.rmcpsuite: 506 unit tests, enabled integration tests, and 48 doctests passed (10 ignored), with the two exclusions below.-D warnings.Two existing process tests remain excluded because the sandbox blocks process-state inspection:
test_tokio_child_process_dropandtest_tokio_child_process_graceful_shutdown. Neither test changed.