Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
The file backend compares both MEMORY.md and facts text when rebuilding its prompt snapshot, but FactsStorage previously returned its first cached value indefinitely. External edits, clearing or deleting facts.json could therefore leave stale facts in later prompts. A later sequential write through an older FactsStorage instance could also overwrite facts added by another instance. FileBasedBackend.invalidate() cleared only the MEMORY.md cache.
This is metadata-based freshness, not concurrent-write safety or strong consistency. Edits preserving both size and mtime require explicit invalidation. Existing malformed-JSON fallback behavior is retained; this does not add JSON recovery or schema validation. Three existing formatting hunks in file_based.py are included to satisfy the configured changed-file formatter.
Validation
Related issue number
None. Identified from the file backend's existing two-source snapshot and invalidation contract. All-state facts issue/PR searches were rechecked on 2026-10-26; no competing fix was found. #1002 changes tool-failure notices, and #994 concerns DefaultMemory rollback, not this facts cache.
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check. Both ran; the existing full-repository failures above remain. Changed-file checks passed.