Repository navigation
Conversation
Bind synchronous call arguments with functools.partial before using the existing executor.
Add nine offline regression and control cases using the real executor, including keyword-only calls and exception propagation.
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
RateLimiter.execute()documents support for synchronous functions with keyword arguments, including itsurl=example. The synchronous branch passes those keywords directly toloop.run_in_executor(), which accepts positional arguments only. The target function is never called and aTypeErroris raised.Bind the callable and its arguments with
functools.partialbefore submitting it to the existing executor. Keep asynchronous call handling, pacing, concurrency and exception propagation unchanged.Add nine offline regression/control cases covering mixed positional and keyword arguments, keyword-only functions, an
executor-named target keyword, existing partials, synchronous calls with no keywords, exception propagation and permit reuse, and asynchronous keyword calls. Tests use the real executor and confirm synchronous functions run off the event-loop thread.This does not change the synchronous bookkeeping or adaptive-rate logic in #923, or interrupted context entry in #1016.
Related issue number
No linked issue; identified from the documented public API.
Validation
git diff --check: passed.Checklist
AI assistance was used for investigation, implementation and regression tests.