fix(infer): ignore SSE heartbeat comments in InferClient - #10086
Merged
hjh0119 merged 1 commit intoSep 10, 2026
Merged
Conversation
hjh0119
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InferClient currently asserts that every nonblank streaming line starts with
data:. Valid SSE comment heartbeats therefore abort generation with AssertionError, including the: OPENROUTER PROCESSINGheartbeat documented by OpenRouter.Skip comment lines in the existing parser, as required by the SSE specification. Data payloads,
[DONE], and server error handling remain unchanged. See OpenRouter's documented heartbeat example.Validation: eight unittest methods pass, including real local aiohttp HTTP streaming with leading/interleaved heartbeats, LF/CRLF, fragmented UTF-8 content,
[DONE], an error after a heartbeat, malformed JSON, comment-only streams, and usage events after a comment resembling [DONE]. The same tests produce ten assertion failures on the baseline. Applicable pre-commit hooks pass. No external API call or GPU is required.