Repository navigation
[v5] Fix checkpoint writes and RL logging - #348
Merged
Merged
Conversation
qychen2001
marked this pull request as draft
October 28, 2026 09:14
qychen2001
marked this pull request as ready for review
October 28, 2026 09:26
| status = self.train_status if is_training else self.eval_status | ||
| if metric_step is None: | ||
| metric_step = self.cur_step - 1 | ||
| metric_step = self.cur_step |
Collaborator
There was a problem hiding this comment.
注意下这里是否是 v5 分支的修改,如果是 main 分支已有代码,看看这里原先的设计是否本就有意义
tastelikefeet
approved these changes
Oct 28, 2026
This reverts commit 8effd74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and changes
修复 v5 RL 的 checkpoint 并发写入与逐样本日志,增加 worker 实际精度诊断。目标分支为
dev-swift-v5。配套 Swift PR:modelscope/ms-swift#10451 (sampler 放置、共置日志调用、RL-04 精度与 RL-14 shuffle)。
Scope and compatibility
按用户要求,已通过 revert 完整撤回 optimizer_group 的 GA 更新边界、公共指标编号、Transformers/Megatron 双 RPC 事务指标以及相关测试修改。恢复修改前行为,本 PR 不再声明修复 RL-01。Swift 的配套步数预算和边界修改也已撤回。
Validation