Repository navigation
Add Qwen3-TTS Twinkle LoRA integration (2/5) - #356
Open
Wallbreazzz wants to merge 6 commits into
Open
Wallbreazzz wants to merge 6 commits into
Wallbreazzz wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Connects the cookbook to Twinkle local-mode model loading, tokenization and LoRA targeting. Model snapshots, gradient assertions and frozen-weight digests live under tests rather than the runtime package. The adapter identifier is retained for checkpoint compatibility.
Part 2/5 of the Qwen3-TTS cookbook proposal (RFC #279), open together for maintainers to assess alongside Swift/TTS integration.
Dependencies
This PR targets upstream main; later layers have cumulative diffs including prerequisites. Review this layer using the exact incremental comparison.
Exact head:
0a8f3d17fa489efe8bdf90815443d9a1686d1adf. Integrate prerequisites first, then update remaining PR diffs, or choose a consolidated integration. These overlapping PRs should not be merged independently in arbitrary order.Validation
791b488f62ae9b5a246e9ab85ce23e61f56a6c02passed targeted native contracts and generated sample-identical audio to the reviewed reference pair.2f2294641f79be1791f2d282da6d96fbc951fe72subsequently passed 2 causal contracts and 4 inference CLI/waveform contracts with installed Twinkle on the remote NPU host. Its minimal entrypoint generated base and existing-adapter audio on one Ascend NPU; both waveforms were independently verified sample-identical to the previously reviewed pair. This is targeted integrated verification, not a rerun of the full training/resume suite or native validation of every intermediate commit.