Repository navigation
ci: release with release-please instead of Changesets - #9
Merged
Merged
Conversation
commit: |
Co-authored-by: Néstor <Nsttt@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
@module-federation/tanstackreleases from Changesets to release-please. From now on the squash-merged PR title (already enforced byValidate PR title) decides the release:fix:→ patch,feat:→ minor, breaking → minor while below 1.0.How a release works after this lands
mainruns the newRelease Pleaseworkflow, which opens or updates achore: release <version>PR. That PR bumpspackages/tanstack/package.json,.release-please-manifest.json, andpackages/tanstack/CHANGELOG.md.0.1.1, nov, no component, same scheme as the existing0.1.0tag) and publishes a GitHub Release.release: publishedevent triggers the existingrelease.yml, which validates tag = package version, reruns the gate, and publishes through npm trusted publishing.release.ymlkeeps its filename andPublishenvironment, so the npm trusted-publisher config stays valid.release-please authenticates with
REPO_SCOPED_TOKEN, the secret the oldRelease Pull Requestworkflow already required. This matters: a release created with the defaultGITHUB_TOKENwould not triggerrelease.yml.Changes
release-please-config.json,.release-please-manifest.json(seeded at the published0.1.0), and.github/workflows/release-please.yml(pinnedgoogleapis/release-please-actionv5.0.0)..changeset/,@changesets/cli, thechangesetscripts, and theRelease Pull Requestworkflow.release.yml'snextpreview no longer callschangeset version --snapshot. It publishes<next patch>-next.<run id>, for example0.1.1-next.123.pr.ymldrops theReleasetitle bypass. release-please titles are conventional, so they pass the check without one..prettierignorecovers the release-please-written CHANGELOG and manifest. release-please emits*bullets and blank-line runs thatprettier --checkwould reject, which would fail both the release PR's CI and the publish gate.docs/RELEASING.mdand updatesTODO.md.test/release-contracts.test.mjscover: the tag scheme matchesrelease.yml's validation, the manifest equals the package version, release-please uses the repo token,release.ymlstill triggers on published releases, no Changesets remain, and the generated files are ignored by Prettier.The two pending changesets don't need carrying over.
tidy-ssr-revalidationis covered by thefix:commit from #5, andfifty-sites-sinwas a placeholderchore: bump.Proof
pnpm format:check,pnpm typecheck,pnpm build:package, andnode --test test/release-contracts.test.mjs test/release-artifacts.test.mjspass locally (31 tests). The full Playwright suite is left to CI.release-please release-pr --dry-run --target-branch=chore/release-pleaseagainst this repo found the0.1.0release and would open:Before merging
REPO_SCOPED_TOKENneeds contents and pull-requests write access on this repo. The old workflow already needed that.Release Pleaserun should open the0.1.1release PR.