Repository navigation
Encode file bytes in Base64 and data URIs - #87
Merged
Merged
Conversation
Finish #45 with persisted multi-chunk binary regression coverage. Co-authored-by: Yudho Ahmad Diponegoro <yudh0002@e.ntu.edu.sg> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #45, preserving @yudho’s fix and credit.
File#base64currently encodes the Mongoid model description (to_s) rather than the stored file contents. Usedataand verify exact Base64 output, binary round-trip, and data URI output from a reloaded multi-chunk upload. Retains existing Base64 wrapping behavior. Updates the old data URI expectation that encoded the same model description.Prepared by an AI on behalf of @dblock.