Repository navigation
Bug 2088862 - Show the animated kit illustration on the Terms of Use onboarding page in Nightly and debug builds. - #430
Closed
t-p-white wants to merge 1 commit into
Conversation
t-p-white
marked this pull request as ready for review
November 4, 2026 14:01
t-p-white
force-pushed
the
terms-of-use-hero-animation
branch
2 times, most recently
from
November 4, 2026 14:21
4e3433e to
3f15697
Compare
Contributor
Author
![mozilla-code-review[bot]](https://avatars.githubusercontent.com/in/3631945?s=60&v=4){kind=small}
There was a problem hiding this comment.
24 issues have been found in this revision.
23 issues are located outside of the files touched by the patch:
mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:339Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:327Error: Static assertion failed due to requirement 'std::integral_constant<bool, false>::value': nsCOMPtr only works for types with IIDs. Either use RefPtr; add an IID to your type with NS_INLINE_DECL_STATIC_IID/ ;or make the nsCOMPtr point to a base class with an IID. [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsINode' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:421Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsIPrincipal' named in nested name specifier [clang-tidy: clang-diagnostic-error]memory/replace/dmd/DMD.h:85Error: Use of undeclared identifier 'MOZ_ASSERT' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: No member named 'EnsureUtf16ValiditySpan' in namespace 'mozilla'; did you mean 'EnsureUTF16Validity'? [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:411Error: No member named 'Utf16ValidUpTo' in namespace 'mozilla' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: Non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring<char16_t>') cannot bind to a temporary of type 'Span<element_type, dynamic_extent>' (aka 'Span<char16_t, dynamic_extent>') [clang-tidy: clang-diagnostic-error]xpcom/string/nsTSubstring.h:22Error: "Using XPCOM strings is limited to code linked into libxul." [clang-tidy: clang-diagnostic-error]xpcom/threads/TimerThreadMonitor.h:70Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:72Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:71Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:69Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:68Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.
mozilla-code-review
Bot
dismissed
their stale review
November 4, 2026 16:04
This review is now deprecated.
There was a problem hiding this comment.
24 issues have been found in this revision.
23 issues are located outside of the files touched by the patch:
mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:339Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:327Error: Static assertion failed due to requirement 'std::integral_constant<bool, false>::value': nsCOMPtr only works for types with IIDs. Either use RefPtr; add an IID to your type with NS_INLINE_DECL_STATIC_IID/ ;or make the nsCOMPtr point to a base class with an IID. [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsINode' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:421Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsIPrincipal' named in nested name specifier [clang-tidy: clang-diagnostic-error]memory/replace/dmd/DMD.h:85Error: Use of undeclared identifier 'MOZ_ASSERT' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: No member named 'EnsureUtf16ValiditySpan' in namespace 'mozilla'; did you mean 'EnsureUTF16Validity'? [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:411Error: No member named 'Utf16ValidUpTo' in namespace 'mozilla' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: Non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring<char16_t>') cannot bind to a temporary of type 'Span<element_type, dynamic_extent>' (aka 'Span<char16_t, dynamic_extent>') [clang-tidy: clang-diagnostic-error]xpcom/string/nsTSubstring.h:22Error: "Using XPCOM strings is limited to code linked into libxul." [clang-tidy: clang-diagnostic-error]xpcom/threads/TimerThreadMonitor.h:70Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:72Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:71Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:69Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:68Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.
corentinbect
approved these changes
Nov 4, 2026
corentinbect
left a comment
corentinbect
left a comment
There was a problem hiding this comment.
Love seeing animation in the onboarding, Kit looks great 🎉
t-p-white
force-pushed
the
terms-of-use-hero-animation
branch
from
November 5, 2026 11:26
3f15697 to
f6d1c51
Compare
Contributor
Author
mozilla-code-review
Bot
dismissed
their stale review
November 5, 2026 13:14
This review is now deprecated.
There was a problem hiding this comment.
23 issues have been found in this revision.
23 issues are located outside of the files touched by the patch:
mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:339Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsIPrincipal' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:421Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsINode' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:327Error: Static assertion failed due to requirement 'std::integral_constant<bool, false>::value': nsCOMPtr only works for types with IIDs. Either use RefPtr; add an IID to your type with NS_INLINE_DECL_STATIC_IID/ ;or make the nsCOMPtr point to a base class with an IID. [clang-tidy: clang-diagnostic-error]memory/replace/dmd/DMD.h:85Error: Use of undeclared identifier 'MOZ_ASSERT' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: Non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring<char16_t>') cannot bind to a temporary of type 'Span<element_type, dynamic_extent>' (aka 'Span<char16_t, dynamic_extent>') [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: No member named 'EnsureUtf16ValiditySpan' in namespace 'mozilla'; did you mean 'EnsureUTF16Validity'? [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:411Error: No member named 'Utf16ValidUpTo' in namespace 'mozilla' [clang-tidy: clang-diagnostic-error]xpcom/string/nsTSubstring.h:22Error: "Using XPCOM strings is limited to code linked into libxul." [clang-tidy: clang-diagnostic-error]xpcom/threads/TimerThreadMonitor.h:69Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:72Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:71Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:70Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:68Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.
mozilla-code-review
Bot
dismissed
their stale review
November 5, 2026 13:14
This review is now deprecated.
There was a problem hiding this comment.
23 issues have been found in this revision.
23 issues are located outside of the files touched by the patch:
mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:339Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsIPrincipal' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:421Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsINode' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:327Error: Static assertion failed due to requirement 'std::integral_constant<bool, false>::value': nsCOMPtr only works for types with IIDs. Either use RefPtr; add an IID to your type with NS_INLINE_DECL_STATIC_IID/ ;or make the nsCOMPtr point to a base class with an IID. [clang-tidy: clang-diagnostic-error]memory/replace/dmd/DMD.h:85Error: Use of undeclared identifier 'MOZ_ASSERT' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: Non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring<char16_t>') cannot bind to a temporary of type 'Span<element_type, dynamic_extent>' (aka 'Span<char16_t, dynamic_extent>') [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: No member named 'EnsureUtf16ValiditySpan' in namespace 'mozilla'; did you mean 'EnsureUTF16Validity'? [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:411Error: No member named 'Utf16ValidUpTo' in namespace 'mozilla' [clang-tidy: clang-diagnostic-error]xpcom/string/nsTSubstring.h:22Error: "Using XPCOM strings is limited to code linked into libxul." [clang-tidy: clang-diagnostic-error]xpcom/threads/TimerThreadMonitor.h:69Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:72Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:71Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:70Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:68Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.
…onboarding page in Nightly and debug builds. The animation plays once and replays when tapped, so `AnimatedIllustration` gains `replayOnClick`. The static fallback is a vector drawable generated from the animation's first frame, so loading and reduced motion show the same pose with no visible jump. The Lottie JSON is the motion kit hero export rewritten for Lottie Android, which ignores the track matte parent key (tp) and drops the final value after a hold keyframe. Shared mattes were duplicated next to each matted layer, layer indices renumbered, and terminal keyframes after holds marked as holds. It renders identically in lottie-web.
t-p-white
force-pushed
the
terms-of-use-hero-animation
branch
from
November 5, 2026 14:45
f6d1c51 to
de351d2
Compare
|
Pull request closed by commit 5d6c813 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
…onboarding page in Nightly and debug builds. r=corentin The animation plays once and replays when tapped, so `AnimatedIllustration` gains `replayOnClick`. The static fallback is the animation's first frame rendered as a vector, so loading and reduced motion show the same pose with no visible jump. The Lottie JSON is the motion kit hero export rewritten for Lottie Android, which ignores the track matte parent key (tp) and drops the final value after a hold keyframe. Shared mattes were duplicated next to each matted layer, layer indices renumbered, and terminal keyframes after holds marked as holds. It renders identically in lottie-web. **Reviewer notes**: To test in debug, enable the `FeatureFlag` `val onboardingFeatureEnabled = Config.channel.isDebug` and have fresh install. Demo https://github.com/user-attachments/assets/22ba5841-da13-41fd-be7a-067795ad2ae4 Pull request: #430
There was a problem hiding this comment.
23 issues have been found in this revision.
23 issues are located outside of the files touched by the patch:
mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsINode' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:327Error: Static assertion failed due to requirement 'std::integral_constant<bool, false>::value': nsCOMPtr only works for types with IIDs. Either use RefPtr; add an IID to your type with NS_INLINE_DECL_STATIC_IID/ ;or make the nsCOMPtr point to a base class with an IID. [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:339Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsIPrincipal' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:421Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]memory/replace/dmd/DMD.h:85Error: Use of undeclared identifier 'MOZ_ASSERT' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: No member named 'EnsureUtf16ValiditySpan' in namespace 'mozilla'; did you mean 'EnsureUTF16Validity'? [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:411Error: No member named 'Utf16ValidUpTo' in namespace 'mozilla' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: Non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring<char16_t>') cannot bind to a temporary of type 'Span<element_type, dynamic_extent>' (aka 'Span<char16_t, dynamic_extent>') [clang-tidy: clang-diagnostic-error]xpcom/string/nsTSubstring.h:22Error: "Using XPCOM strings is limited to code linked into libxul." [clang-tidy: clang-diagnostic-error]xpcom/threads/TimerThreadMonitor.h:69Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:72Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:70Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:68Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:71Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.
There was a problem hiding this comment.
23 issues have been found in this revision.
23 issues are located outside of the files touched by the patch:
mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:48Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]mfbt/RefPtr.h:49Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsINode' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:327Error: Static assertion failed due to requirement 'std::integral_constant<bool, false>::value': nsCOMPtr only works for types with IIDs. Either use RefPtr; add an IID to your type with NS_INLINE_DECL_STATIC_IID/ ;or make the nsCOMPtr point to a base class with an IID. [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:339Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Incomplete type 'nsIPrincipal' named in nested name specifier [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:421Error: No matching function for call to 'ToSupports' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:361Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsINode' [clang-tidy: clang-diagnostic-error]xpcom/base/nsCOMPtr.h:358Error: Member access into incomplete type 'nsIPrincipal' [clang-tidy: clang-diagnostic-error]memory/replace/dmd/DMD.h:85Error: Use of undeclared identifier 'MOZ_ASSERT' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: No member named 'EnsureUtf16ValiditySpan' in namespace 'mozilla'; did you mean 'EnsureUTF16Validity'? [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:411Error: No member named 'Utf16ValidUpTo' in namespace 'mozilla' [clang-tidy: clang-diagnostic-error]xpcom/string/nsReadableUtils.h:422Error: Non-const lvalue reference to type 'nsAString' (aka 'nsTSubstring<char16_t>') cannot bind to a temporary of type 'Span<element_type, dynamic_extent>' (aka 'Span<char16_t, dynamic_extent>') [clang-tidy: clang-diagnostic-error]xpcom/string/nsTSubstring.h:22Error: "Using XPCOM strings is limited to code linked into libxul." [clang-tidy: clang-diagnostic-error]xpcom/threads/TimerThreadMonitor.h:69Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:72Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:70Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:68Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.xpcom/threads/TimerThreadMonitor.h:71Error: Deleted member function should be public [clang-tidy: modernize-use-equals-delete,-warnings-as-errors]
Checker reliability is high, meaning that the false positive ratio is low.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The animation plays once and replays when tapped, so
AnimatedIllustrationgainsreplayOnClick. The static fallback is the animation's first frame rendered as a vector, so loading and reduced motion show the same pose with no visible jump.The Lottie JSON is the motion kit hero export rewritten for Lottie Android, which ignores the track matte parent key (tp) and drops the final value after a hold keyframe. Shared mattes were duplicated next to each matted layer, layer indices renumbered, and terminal keyframes after holds marked as holds. It renders identically in lottie-web.
Reviewer notes: To test in debug, enable the
FeatureFlagval onboardingFeatureEnabled = Config.channel.isDebugand have fresh install.Demo
Screen_recording_20261104_135936.mp4
Lando: link
Bugzilla: bug 2088862
🚫 This pull request has 1 blocker.