Repository navigation
Conversation
t-p-white
commented
Nov 11, 2026
Comment on lines
+32
to
+34
| // our specific scope, but we don't have this capability today. We've tried doing this in the | ||
| // `FxaAccountStoreSync` but because our AuthCustomTabActivity extends from `HomeActivity` those | ||
| // observes experience an "Authentication" event immediately that resets the state machine. |
…airing link. r=#android-reviewers,corentin AuthCustomTabActivity runs in its own task, so when a pairing link launches Firefox from another app, finishing it on success returns the user to that app instead of Firefox.
|
No new issues detected. This pull request is 🆗 |
1 similar comment
|
No new issues detected. This pull request is 🆗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthCustomTabActivityruns in its own task, so when a pairing link launches Firefox from another app, finishing it onsuccess returns the user to that app instead of Firefox.
Lando: link
Bugzilla: bug 2090906
🚫 This pull request has 3 blockers.