Repository navigation
Oct 21st - #1123
Merged
Merged
Oct 21st#1123
Conversation
⬆️ Update all npm dependencies (2026-09-16) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Show a notice when column filters hide result rows
Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.9.13 to 2.11.24. - [Release notes](https://github.com/web-platform-dx/baseline-browser-mapping/releases) - [Commits](web-platform-dx/baseline-browser-mapping@v2.9.13...v2.11.24) --- updated-dependencies: - dependency-name: baseline-browser-mapping dependency-version: 2.11.21 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.28.1 to 4.29.0. - [Release notes](https://github.com/browserslist/browserslist/releases) - [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md) - [Commits](browserslist/browserslist@4.28.1...4.29.0) --- updated-dependencies: - dependency-name: browserslist dependency-version: 4.28.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.0.6 to 3.1.8. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.0.6...v3.1.8) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.3 to 8.5.28. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.3...8.5.28) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.28 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@humanfs/node](https://github.com/humanwhocodes/humanfs/tree/HEAD/packages/node) from 0.16.6 to 0.16.8. - [Release notes](https://github.com/humanwhocodes/humanfs/releases) - [Changelog](https://github.com/humanwhocodes/humanfs/blob/main/packages/node/CHANGELOG.md) - [Commits](https://github.com/humanwhocodes/humanfs/commits/node-v0.16.8/packages/node) --- updated-dependencies: - dependency-name: "@humanfs/node" dependency-version: 0.16.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [websocket-driver](https://github.com/faye/websocket-driver-node) from 0.7.4 to 0.7.5. - [Changelog](https://github.com/faye/websocket-driver-node/blob/main/CHANGELOG.md) - [Commits](faye/websocket-driver-node@0.7.4...0.7.5) --- updated-dependencies: - dependency-name: websocket-driver dependency-version: 0.7.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
⬆️ Update all npm dependencies (2026-09-24) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
[bug-2039589] Add caching to treeherder requests [bug-2039589] Clear cache when in tests Apply batched suggestions from code review Co-authored-by: beatrice-acasandrei <69891317+beatrice-acasandrei@users.noreply.github.com> [bug-2039589] Remove unneed clearning of a memoize function
…1110) * significance filter and sort now stay applied when the page is reloaded or the link is shared * localStorage lines are read when each store is created vs module load
…#1102) * Bug 1982588: Align breadcrumbs and replicates button on the same line in Subtests View Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1982588 * Bug 1982588: Align breadcrumbs and replicates button on the same line in Subtests View Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1982588 * Bug 1982588: Address review nits on Subtests header layout Drop component='h2' from the replicates button Grid wrapper, and use MUI spacing gap: 1. Update snapshots. --------- Co-authored-by: moijes12 <4566851+moijes12@users.noreply.github.com>
Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.10.0 to 1.12.0. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.10.0...v1.12.0) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.12.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* [bug-1941337] Add new formatter for delta values * [bug-1941337] Fix lint * [bug-1941337] Be consistent with expanded and collapse results * [bug-1941337] Fix lint --------- Co-authored-by: gopar <gopardanie@gmail.com>
* ⬆️ Update all npm dependencies (2026-09-29) * Bump shell-quote from 1.10.0 to 1.12.0 (#1113) Bumps [shell-quote](https://github.com/ljharb/shell-quote) from 1.10.0 to 1.12.0. - [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md) - [Commits](ljharb/shell-quote@v1.10.0...v1.12.0) --- updated-dependencies: - dependency-name: shell-quote dependency-version: 1.12.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bug-1941337 - Add new formatter for delta values (#1112) * [bug-1941337] Add new formatter for delta values * [bug-1941337] Fix lint * [bug-1941337] Be consistent with expanded and collapse results * [bug-1941337] Fix lint --------- Co-authored-by: gopar <gopardanie@gmail.com> * Transform @remix-run/route-pattern in jest react-router 8.4.0 depends on the ESM-only @remix-run/route-pattern, which jest can't load without transforming it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ⬆️ Update all npm dependencies (2026-09-29) * Transform @remix-run/route-pattern in jest react-router 8.4.0 depends on the ESM-only @remix-run/route-pattern, which jest can't load without transforming it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gopar <gopar@users.noreply.github.com> Co-authored-by: gopar <gopardanie@gmail.com> Co-authored-by: Carla Severe <csevere@mozilla.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Bumps [source-map-js](https://github.com/7rulnik/source-map-js) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/7rulnik/source-map-js/releases) - [Changelog](https://github.com/7rulnik/source-map-js/blob/main/CHANGELOG.md) - [Commits](7rulnik/source-map-js@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: source-map-js dependency-version: 1.2.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kala Severe <csevere@mozilla.com>
Bumps [proxy-addr](https://github.com/jshttp/proxy-addr) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/jshttp/proxy-addr/releases) - [Changelog](https://github.com/jshttp/proxy-addr/blob/master/HISTORY.md) - [Commits](jshttp/proxy-addr@v2.0.7...v2.0.8) --- updated-dependencies: - dependency-name: proxy-addr dependency-version: 2.0.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pbkdf2](https://github.com/browserify/pbkdf2) from 3.1.3 to 3.1.7. - [Changelog](https://github.com/browserify/pbkdf2/blob/master/CHANGELOG.md) - [Commits](browserify/pbkdf2@v3.1.3...v3.1.7) --- updated-dependencies: - dependency-name: pbkdf2 dependency-version: 3.1.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [compression](https://github.com/expressjs/compression) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/expressjs/compression/releases) - [Changelog](https://github.com/expressjs/compression/blob/master/HISTORY.md) - [Commits](expressjs/compression@v1.8.1...v1.8.2) --- updated-dependencies: - dependency-name: compression dependency-version: 1.8.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) from 7.4.2 to 7.4.6. - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v7.4.6/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v7.4.2...v7.4.6) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-version: 7.4.6 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [handlebars](https://github.com/handlebars-lang/handlebars.js) from 4.7.9 to 4.7.10. - [Release notes](https://github.com/handlebars-lang/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/v4.7.10/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.9...v4.7.10) --- updated-dependencies: - dependency-name: handlebars dependency-version: 4.7.10 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* ⬆️ Update all npm dependencies (2026-10-20) * update package.json --------- Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Carla Severe <csevere@mozilla.com>
kala-moz
requested review from
beatrice-acasandrei and
esanuandra
as code owners
October 21, 2026 02:38
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
🟡 Changes recommended
Comparison caches can retain incomplete results indefinitely, and the framework selector introduces unnamed focusable checkboxes.
2 open issues
What changed in this PR
This PR expands PerfCompare’s multi-framework comparisons and improves result presentation and persistence.
Changes:
- Adds framework multiselects, separate framework requests, and partial-failure notices.
- Caches comparisons, restores significance preferences, and explains filtered-out rows.
- Updates delta formatting, subtest layout, tests, and dependencies.
| File | Description |
|---|---|
| src/utils/format.ts | Adds signed delta formatting. |
| src/resources/Strings.tsx | Adds selector and notice text. |
| src/reducers/ColumnPrefsSlice.ts | Initializes advanced columns from URLs. |
| src/logic/treeherder.ts | Adds comparison caching and failure eviction. |
| src/hooks/useTableFilters.ts | Summarizes rows hidden by filters. |
| src/components/Shared/FrameworkMultiSelect.tsx | Adds shared framework multiselect. |
| src/components/Shared/FrameworkDropdown.tsx | Removes single-framework selector. |
| src/components/Search/SearchFrameworkDropdown.tsx | Integrates framework multiselect. |
| src/components/Search/SearchContainer.tsx | Passes framework arrays. |
| src/components/Search/loader.ts | Uses shared framework default. |
| src/components/Search/CompareWithBase.tsx | Submits multiple frameworks. |
| src/components/Search/CompareOverTime.tsx | Submits multiple frameworks. |
| src/components/CompareResults/TestHeader.tsx | Displays framework names. |
| src/components/CompareResults/TableContent.tsx | Separates frameworks and displays filter notices. |
| src/components/CompareResults/SubtestsResults/SubtestsResultsTable.tsx | Displays subtest filter notices. |
| src/components/CompareResults/SubtestsResults/SubtestsResultsMain.tsx | Aligns breadcrumbs and replicates toggle. |
| src/components/CompareResults/SubtestsResults/SubtestsBreadcrumbs.tsx | Removes redundant spacing. |
| src/components/CompareResults/subtestsOverTimeLoader.tsx | Uses shared framework default. |
| src/components/CompareResults/subtestsLoader.ts | Uses shared framework default. |
| src/components/CompareResults/ResultsView.tsx | Passes selected framework arrays. |
| src/components/CompareResults/ResultsTable.tsx | Synchronizes framework selection with URLs. |
| src/components/CompareResults/ResultsMain.tsx | Adds failed-framework banner. |
| src/components/CompareResults/ResultsControls.tsx | Commits framework changes on menu close. |
| src/components/CompareResults/OverTimeResultsView.tsx | Passes selected framework arrays. |
| src/components/CompareResults/overTimeLoader.ts | Loads multiple frameworks with partial-failure handling. |
| src/components/CompareResults/loader.ts | Validates and loads multiple frameworks. |
| src/components/CompareResults/landoToCommitLoader.ts | Preserves multiple framework parameters. |
| src/components/CompareResults/hashToCommitLoader.ts | Preserves multiple framework parameters. |
| src/components/CompareResults/FilteredRowsNotice.tsx | Explains hidden result rows. |
| src/common/testVersions/studentT.tsx | Applies signed delta formatting. |
| src/common/constants.ts | Centralizes framework defaults and ordering. |
| src/__tests__/utils/setupTests.ts | Resets caches, URLs, and preferences. |
| src/__tests__/Search/SearchView.test.tsx | Tests multi-framework submissions. |
| src/__tests__/Search/CompareWithBase.test.tsx | Tests multiselect behavior and URLs. |
| src/__tests__/Search/CompareOverTime.test.tsx | Tests over-time multiselect behavior. |
| src/__tests__/Search/__snapshots__/SearchView.test.tsx.snap | Updates selector snapshots. |
| src/__tests__/Search/__snapshots__/SearchResultsList.test.tsx.snap | Updates selector snapshots. |
| src/__tests__/Search/__snapshots__/SearchContainer.test.tsx.snap | Updates selector snapshots. |
| src/__tests__/Search/__snapshots__/CompareWithBase.test.tsx.snap | Captures multiselect presentation. |
| src/__tests__/Search/__snapshots__/CompareOverTime.test.tsx.snap | Captures multiselect presentation. |
| src/__tests__/format.test.ts | Tests signed delta formatting. |
| src/__tests__/CompareResults/SubtestsRevisionRow.test.tsx | Expects signed deltas. |
| src/__tests__/CompareResults/SubtestsResultsView.test.tsx | Updates delta expectations. |
| src/__tests__/CompareResults/RevisionRowExpandable.test.tsx | Checks signed mean and median differences. |
| src/__tests__/CompareResults/ResultsView.test.tsx | Tests selectors and framework labels. |
| src/__tests__/CompareResults/ResultsTable.test.tsx | Tests grouping, persistence, and notices. |
| src/__tests__/CompareResults/FilteredRowsNotice.test.tsx | Tests notice counts and explanations. |
| src/__tests__/CompareResults/__snapshots__/SubtestsRevisionRow.test.tsx.snap | Captures signed deltas. |
| src/__tests__/CompareResults/__snapshots__/SubtestsResultsView.test.tsx.snap | Captures header alignment. |
| src/__tests__/CompareResults/__snapshots__/ResultsView.test.tsx.snap | Captures selector and framework labels. |
| src/__tests__/CompareResults/__snapshots__/OverTimeResultsView.test.tsx.snap | Captures selector and framework labels. |
| src/__tests__/App.test.tsx | Tests framework requests and failure banners. |
| package.json | Updates runtime and development dependencies. |
| jest.config.ts | Transforms an additional router dependency. |
| .gitignore | Ignores CLAUDE.md. |
| .github/copilot-instructions.md | Documents repository development guidance. |
Review effort: Balanced
| value={ALL_FRAMEWORKS_VALUE} | ||
| className={`framework-dropdown-item`} | ||
| > | ||
| <Checkbox checked={isAllSelected} size='small' /> |
Comment on lines
+296
to
+297
| const cached = compareResultsCache.get(key); | ||
| if (cached) return cached; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Highlights:
[kala-moz]:
Bug 2058236: Show a notice when column filters hide result rows
Bug: 2075044 Significance filter and sort selections don't persist
[gopar]:
Bug-2039589 - Add caching to ttest/mwu views
Bug 1846013 Add ability to display multiple framework results
Bug-1941337 - Add new formatter for delta values
[moijes]