Skip to content

fix(vulnerability): remove URGENT priority from sorting and update related documentation - #513

Open
ybelMekk wants to merge 14 commits into
fix/priorityfrom
fix/priority-remove-urgent-sort
Open

fix(vulnerability): remove URGENT priority from sorting and update related documentation#513
ybelMekk wants to merge 14 commits into
fix/priorityfrom
fix/priority-remove-urgent-sort

Conversation

@ybelMekk

@ybelMekk ybelMekk commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Follow-up to fix/priority PR

This branch is stacked on fix/priority; the PR base is set to that branch, so GitHub will retarget this to main once the parent merges. Merge the parent first.

This pull request removes the "urgent" vulnerability priority as an order-by field from the vulnerability summary features. This field was deprecated because URGENT depends on a workload's internet exposure, which isn't available when counts are aggregated across workloads at summary scope — so the count is always 0 there and the ordering is a no-op. The change cleans up the codebase by removing all references to this field across the GraphQL schema, generated code, models, and sorting logic.

Technically a breaking GraphQL change (enum value removal), but verified safe: console-frontend has zero references to VULNERABILITY_PRIORITY_URGENT outside generated files. CVEPriority.URGENT is untouched — it's still returned per-workload by CVE.priority / WorkloadVulnerability.priority.

GraphQL Schema and API Cleanup:

  • Removed the VULNERABILITY_PRIORITY_URGENT order-by field from the GraphQL schema (vulnerability.graphqls) and the generated Go code (root_.generated.go). [1] [2]

Model and Validation Updates:

  • Removed the VulnerabilitySummaryOrderByFieldVulnerabilityPriorityUrgent constant and all references from the vulnerability models, including the list of valid fields and the validation logic in models.go. [1] [2]

Sorting and Filtering Logic:

  • Removed the deprecated urgent priority sorting logic and registration from the workload summary sorting/filtering code in sortfilter.go. [1] [2]

@ybelMekk
ybelMekk requested a review from a team as a code owner September 7, 2026 06:43
ybelMekk and others added 4 commits September 8, 2026 11:33
…xploited

Bump github.com/nais/v13s/pkg/api to bd6d431 (renames Summary.ActNow to
Summary.KevCount, wire-compatible). Remove the always-zero
countsByPriority.urgent counter and expose a proper knownExploited count
sourced from KevCount instead. Keep severity ints and hasSBOM as
deprecated-but-present fields.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ybelMekk and others added 4 commits September 8, 2026 13:32
…xploited

Bump github.com/nais/v13s/pkg/api to bd6d431 (renames Summary.ActNow to
Summary.KevCount, wire-compatible). Remove the always-zero
countsByPriority.urgent counter and expose a proper knownExploited count
sourced from KevCount instead. Keep severity ints and hasSBOM as
deprecated-but-present fields.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ybelMekk and others added 2 commits September 8, 2026 13:35
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant