refactor(graphql): use pointers for optional genqlient fields - #761
Merged
Conversation
Contributor
📝 Changelog previewBelow is a preview of the Changelog that will be added to the next release. Only commit messages that follow the Conventional Commits specification will be included in the Changelog. v5.46.3 - 2026-09-09Full Changelog: v5.46.2...v5.46.3 ⚙️ Miscellaneous Changes
|
Set `optional: pointer` in genqlient.yaml so optional GraphQL fields (inputs and outputs) are generated as pointers with omitempty JSON tags instead of plain values. This lets input structs properly distinguish "not provided" from an explicit zero value, and makes response-side optionality explicit instead of silently collapsing to Go zero values. (Might be worth looking at `pointer_omitempty` when a new version is released of genqlient. Khan/genqlient#413 and Khan/genqlient#406)
christeredvartsen
force-pushed
the
default_ptr
branch
from
September 9, 2026 07:44
026c5dc to
f494235
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
optional: pointerin genqlient.yaml so optional GraphQL fields (inputs and outputs) are generated as pointers with omitempty JSON tags instead of plain values. This lets input structs properly distinguish "not provided" from an explicit zero value, and makes response-side optionality explicit instead of silently collapsing to Go zero values. (Might be worth looking atpointer_omitemptywhen a new version is released of genqlient. Khan/genqlient#413 and Khan/genqlient#406)E.g.
nais config listdidn't show used configs given that the default for the filter wasinUse: falseand not unset/null.