Repository navigation
Simplify ScrollView responder logic - #2940
Merged
Merged
Conversation
|
Size Change: -361 B (-0.37%) Total Size: 96.3 kB 📦 View Changed
|
Kudo
approved these changes
Oct 29, 2026
zoontek
force-pushed
the
simplify-scrollview-responder
branch
from
October 30, 2026 09:47
56a12ac to
933750c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes scroll responder code that was ported from React Native but never ran on web. Momentum, drag, and keyboard events are not emitted on web, so their handlers and the "is animating" check had no effect.
Behavior changes:
disableScrollViewPanResponderproponResponderTerminatenow reaches the user's handler. Before, it was replaced withundefined.scrollResponderZoomTonow throws, as on Android. Before, the invariant had a truthy string as its condition, so it never fired.scrollResponderScrollTo(x, y, animated)is no longer supported. Use the options object.scrollTostill accepts the old signature.additionalScrollOffsetis now reset after scrolling to a focused input. Before, the code reset a misnamed field.