Repository navigation
Fix the phpstan errors on master - #606
Merged
Merged
Conversation
The baseline of nemiah#603 was generated before nemiah#594, nemiah#598 and nemiah#601 were merged, so master reports 19 errors. They are fixed in the code instead of being added to the baseline: - Return types for the new test methods and HKWPDv6::setPaginationToken(). - Array value types for GetSEPAAccounts::__serialize()/__unserialize() and the CAMT data provider. - GetSEPAAccountsTest builds the UPD from HIUPDv6 segments, as UPD::$hiupd expects. - HIUPDTest converts its examples in a typed helper (self:: instead of static::), which also clears the six baselined parse() errors. - Drop the two CAMT baseline entries that nemiah#601 made obsolete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHPStan job fails on master with 19 errors. The baseline of #603 was generated on 10.10., before #592, #594, #598 and #601 were merged on 29.10., so it neither covers the new code nor knows that #601 already fixed two baselined CAMT errors.
This PR fixes them in the code instead of growing the baseline:
GetSEPAAccountsTest,HIUPDTest,HKWPDTest) andHKWPDv6::setPaginationToken().GetSEPAAccounts::__serialize()/__unserialize()and the data provider inCAMTStructuredFieldsTest.GetSEPAAccountsTestbuilds the UPD fromHIUPDv6segments, asUPD::$hiupdexpectsHIUPD.HIUPDTestconverts its HBCI 2.2 examples in a small typed helper (self::instead ofstatic::). This also clears the six baselinedparse()errors, so that entry is removed.No functional change. PHPStan reports 0 errors, PHPUnit 205 tests green, php-cs-fixer clean.
Note for #605: it removes a different baseline entry (MT535), both PRs touch separate blocks of
phpstan-baseline.neon.This is (partly) generated code and I as human vouch for it's correctness.
I am using this code in my own repo. If something breaks, i'll fix it. Greets, Felix