Skip to content

Show avatars in activity list#14634

Open
tobiasKaminsky wants to merge 7 commits into
masterfrom
showAvatars
Open

Show avatars in activity list#14634
tobiasKaminsky wants to merge 7 commits into
masterfrom
showAvatars

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Mar 5, 2025

Copy link
Copy Markdown
Member
  • Tests written, or not not needed

@tobiasKaminsky tobiasKaminsky mentioned this pull request Feb 26, 2025
Open
2 tasks
@tobiasKaminsky tobiasKaminsky linked an issue Mar 5, 2025 that may be closed by this pull request
Show avatars in notifications and activity (like in server) #14597
Open
2 tasks
@tobiasKaminsky tobiasKaminsky linked an issue Jun 26, 2025 that may be closed by this pull request
Show avatars in notifications and activity (like in server) nextcloud/server#16207
Open
4 tasks
@tobiasKaminsky
tobiasKaminsky marked this pull request as ready for review November 21, 2025 06:38
ZetaTom
ZetaTom requested changes Jan 8, 2026
View reviewed changes

@ZetaTom ZetaTom left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works in general with some issues. Please implement the changes I suggested.

Filenames in file details also appear red with this change in place - see following screenshot on the right.

image

Sometimes avatars aren't rendered correctly and the placeholder is cut off. The user account Charlie has an avatar set, which is correctly displayed elsewhere.

Untitled

Comment thread app/src/main/java/third_parties/fresco/BetterImageSpan.kt Outdated
Comment thread app/src/main/res/drawable/accent_circle.xml
Comment thread app/src/main/res/xml/chip_others.xml
Comment thread app/src/main/java/com/nextcloud/utils/text/Spans.java Outdated
Comment thread app/src/main/res/layout/activity_list_item.xml Outdated
@tobiasKaminsky

tobiasKaminsky commented Jan 22, 2026

Copy link
Copy Markdown
Member Author

@ZetaTom red filename and avatar size fixed.

@alperozturk96 alperozturk96 added this to the Nextcloud App 3.36.0 milestone Feb 4, 2026
alperozturk96
alperozturk96 requested changes Feb 4, 2026
View reviewed changes

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shared user name is not displaying correctly and the UI gets stuck in a loading state.

Screen.Recording.2026-02-04.at.09.36.34.mov

Codacy

Image

@tobiasKaminsky

tobiasKaminsky commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

probably recycler view problem: set has stable ids -> true?

new issue: adding comment not displayed/ refreshed in android

@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14634.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@ZetaTom
ZetaTom removed their request for review March 14, 2026 19:17
@tobiasKaminsky
Show avatars in activity list
6191274 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
Rename .java to .kt
2cf36d1 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
fix spotless
986d84e 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
fix detekt
9acc468 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky
wip
055fd3e 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29567297810/artifacts/8401758481
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky and others added 2 commits July 17, 2026 16:00
@tobiasKaminsky @alperozturk96
Show avatars in activity list
3454b7a 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/adapter/ActivityListAdapter.java
#	app/src/main/java/third_parties/fresco/BetterImageSpan.kt
#	app/src/main/res/values/styles.xml
@alperozturk96
remove old Spans.java
ebee2f3 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
alperozturk96 requested changes Jul 17, 2026
View reviewed changes

@alperozturk96 alperozturk96 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks okay but still I can see the infinite loading.

Screen_recording_20260717_160547.mp4

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/29586478791/artifacts/8409392726
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3232
Correctness6666
Dodgy code213213
Experimental11
Malicious code vulnerability22
Multithreaded correctness2525
Performance4141
Security1919
Total399399

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14634-IT-master-16-43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes
@ZetaTom ZetaTom ZetaTom requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

3. to review enhancement

Projects

None yet

Milestone

Nextcloud App 33.1.0

Development

Successfully merging this pull request may close these issues.

Show avatars in notifications and activity (like in server) Show avatars in notifications and activity (like in server)

4 participants

@tobiasKaminsky @alperozturk96 @ZetaTom @AndyScherzinger