Skip to content

correct unit in server memory recommendations - #15698

Open
MrRinkana wants to merge 3 commits into
nextcloud:masterfrom
MrRinkana:patch-1
Open

MrRinkana wants to merge 3 commits into
nextcloud:masterfrom
MrRinkana:patch-1

Conversation

@MrRinkana

Copy link
Copy Markdown

ps -o rss reports values in kikibytes, not kilobytes: https://man7.org/linux/man-pages/man1/ps.1.html

The command iself then uses 1024 to convert to MiB

As the section is about memory estimations, accuracy is important

Changes MB to MiB in two locations: the command output and text showing common nextcould fpm memory use

ps -o rss reports values in kikibytes, not kilobytes: https://man7.org/linux/man-pages/man1/ps.1.html

The command iself then uses 1024 to convert to MiB

As the section is about memory estimations, accuracy is important

Signed-off-by: Rinkana <39345772+MrRinkana@users.noreply.github.com>
@tflidd

tflidd commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

on debian trixie they say that they use kilobytes....

       rss         RSS       resident set size, the non-swapped physical memory
                             that  a  task  has  used  (in  kilobytes).  (alias
                             rssize, rsz).

@MrRinkana

Copy link
Copy Markdown
Author

@tflidd
That is an documentation issue in procps which was fixed in more recent versions; it has always actually been kikibytes.

https://gitlab.com/procps-ng/procps/-/merge_requests/211

Also the division done in the command here is by 1024 which means it cannot be MB (and if PS had been returning KB the resulting value was nonsensical: neither MB or MiB)

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@MrRinkana

Copy link
Copy Markdown
Author

@tflidd
Could you have a look, seems to fail and I don't understand why, is there something I can do?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants