Skip to content

[stable5.3] fix(migration): make option_type migration self-sufficient - #3604

Merged
Chartman123 merged 1 commit into
stable5.3from
backport/3603/stable5.3
Aug 25, 2026
Merged

[stable5.3] fix(migration): make option_type migration self-sufficient#3604
Chartman123 merged 1 commit into
stable5.3from
backport/3603/stable5.3

Conversation

@backportbot

@backportbot backportbot Bot commented Aug 25, 2026

Copy link
Copy Markdown

Backport of PR #3603

Version050300Date20260716000000 guarded changeSchema() against a missing
option_type column but ran an unguarded UPDATE on it in postSchemaChange(),
aborting occ upgrade on any instance where the column was absent. Create the
column when missing and guard the backfill in both migrations.

Fixes #3562

Assisted-by: Claude Code:claude-opus-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@backportbot backportbot Bot added the 3. to review Waiting for reviews label Aug 25, 2026
@Chartman123
Chartman123 enabled auto-merge August 25, 2026 13:47
@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Migration/Version050300Date20260716000000.php 0.00% 15 Missing ⚠️
lib/Migration/Version050300Date20250914000000.php 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123
Chartman123 merged commit e9005dd into stable5.3 Aug 25, 2026
51 of 52 checks passed
@Chartman123
Chartman123 deleted the backport/3603/stable5.3 branch August 25, 2026 15:13
@Chartman123
Chartman123 restored the backport/3603/stable5.3 branch August 25, 2026 20:59
@Chartman123
Chartman123 deleted the backport/3603/stable5.3 branch August 25, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants