Skip to content

fix: don't validate unaffected columns of a row upon inline editing - #3007

Merged
blizzz merged 4 commits into
mainfrom
fix/2990/inline-edit-mandatory
Sep 16, 2026
Merged

blizzz merged 4 commits into
mainfrom
fix/2990/inline-edit-mandatory

Conversation

@blizzz

@blizzz blizzz commented Sep 14, 2026

Copy link
Copy Markdown
Member

✔️ First commit to ensure the test is resulting in a failure
✔️ Second commit carries the actual fix
✔️ Third commit to add a failing test to catch an edge case (numbers treated as 0 and valid while not actually given)
✔️ commit fixing that an empty number values passes a valid (not including progress bar or stars e.g.)

The impact is also that a value, which column turned from non-mandatory to mandatory, can stay empty after an inline edit. But so it also could remain frozen with the missing value. Imo an acceptable tradeoff.

Todo

  • Edit modal allows to unset mandatory value now 🙃
  • Flicker/data reload after save from inline-edit unrelated, same on main

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stableX.X
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…atory

Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug Something isn't working 2. developing Work in progress labels Sep 14, 2026
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz changed the title WIP: fix for 2990 fix: don't validate unaffected columns of a row upon inline editing Sep 14, 2026
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Assisted-by: ClaudeCode:claude-opus-5
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzz marked this pull request as ready for review September 14, 2026 21:47
@blizzz
blizzz requested a review from enjeck as a code owner September 14, 2026 21:47
@blizzz
blizzz requested review from Koc and samin-z September 14, 2026 21:47
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 14, 2026
@blizzz
blizzz merged commit b00bedc into main Sep 16, 2026
84 checks passed
@blizzz
blizzz deleted the fix/2990/inline-edit-mandatory branch September 16, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants