fix: don't validate unaffected columns of a row upon inline editing - #3007
Merged
Merged
Conversation
…atory Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
marked this pull request as ready for review
September 14, 2026 21:47
Koc
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✔️ First commit to ensure the test is resulting in a failure
✔️ Second commit carries the actual fix
✔️ Third commit to add a failing test to catch an edge case (numbers treated as 0 and valid while not actually given)
✔️ commit fixing that an empty number values passes a valid (not including progress bar or stars e.g.)
The impact is also that a value, which column turned from non-mandatory to mandatory, can stay empty after an inline edit. But so it also could remain frozen with the missing value. Imo an acceptable tradeoff.
Todo
Flicker/data reload after save from inline-editunrelated, same on main🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)