fix(SyncService): Behave like an idle disconnect on 403 responses - #9192
Open
mejo- wants to merge 1 commit into
Open
fix(SyncService): Behave like an idle disconnect on 403 responses#9192mejo- wants to merge 1 commit into
mejo- wants to merge 1 commit into
Conversation
When the editing session went invalid (i.e. because a browser or tab was sleeping and didn't send a heartbeat for more than five minutes), the server replies with 403 responses to sync/push requests. The client-side polling backend correctly disconnects but the push side (sync service) continues to send push requests with awareness state updates and optionally pending steps. This commit changes the sync service to stop pushing to the server on 403s as well by invalidating the session client-side. The UI now handles the `PUSH_FORBIDDEN` error like an idle disconnect: it sets the `idle` state which causes the status badge with reconnect button to be displayed. Fixes: #8950 Signed-off-by: Jonas <jonas@freesources.org> Assisted-by: ClaudeCode:claude-fable-5-1
github-project-automation
Bot
moved this to 馃Л Planning evaluation (don't pick)
in 馃摑 Productivity team
mejo-
moved this from 馃Л Planning evaluation (don't pick)
to 馃憖 In review
in 馃摑 Productivity team
Member
Author
|
/backport to stable35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the editing session went invalid (i.e. because a browser or tab was sleeping and didn't send a heartbeat for more than five minutes), the server replies with 403 responses to sync/push requests.
The client-side polling backend correctly disconnects but the push side (sync service) continues to send push requests with awareness state updates and optionally pending steps.
This commit changes the sync service to stop pushing to the server on 403s as well by invalidating the session client-side.
The UI now handles the
PUSH_FORBIDDENerror like an idle disconnect: it sets theidlestate which causes the status badge with reconnect button to be displayed.Fixes: #8950
Assisted-by: ClaudeCode:claude-fable-5-1
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)馃 AI (if applicable)