feat: only include the architectures supported in version.json#2494
feat: only include the architectures supported in version.json#2494nschonni wants to merge 6 commits into
Conversation
aded288 to
4598df7
Compare
|
Although there is still a Shellcheck issue, I'm marking this as "ready" for a review, because with the upcoming Alpine changes, it probably would be good to make sure that what is marked as supported at the core matches what we're building here. |
|
I left them out of the diff, but if this is going to land, I'd add the keychanges from #2551 and add them as a separate commit to do one big rebuild at the same time |
|
We don't have an agreed strategy for making changes like this that affect the Dockerfiles but in themselves don't require new Docker builds. For the @sxa key, Stuart submitted PR #2551 to change the key only (no Dockerfiles). I then did a dummy PR with updated Dockerfiles to run CI tests, which I closed unmerged after the tests were successful. If that sounds like a good general strategy, we could maybe formalize it separately. If applied here, it would mean submitting a separate PR that only updated the Dockerfile templates and |
Description
Motivation and Context
There is likely still some drift between the values in
architecturesandversion.json, but move more towards only including architectures in the Dockerfile that have been marked supported.Testing Details
Example Output(if appropriate)
Types of changes
Checklist