Skip to content

feat: add RemoteLoadableBanner component to layout#111

Merged
avivkeller merged 2 commits into
mainfrom
remote-banner
Jul 4, 2026
Merged

feat: add RemoteLoadableBanner component to layout#111
avivkeller merged 2 commits into
mainfrom
remote-banner

Conversation

@bmuenzenmeyer

@bmuenzenmeyer bmuenzenmeyer commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Adds the missing banner driven off of https://nodejs.org/site.json

This helps preserve a unified experience - even if there is a loading state

Copilot AI review requested due to automatic review settings July 4, 2026 13:49
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner July 4, 2026 13:49
@cursor

cursor Bot commented Jul 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single UI addition reusing an existing doc-kit banner component; no auth, data, or routing changes.

Overview
Adds the shared RemoteLoadableBanner from doc-kit at the top of the learn layout so announcement content from nodejs.org/site.json can show on learn pages, matching the main site (including a loading state while remote config loads).

The change is limited to importing the component and rendering it above analytics, nav, and article content in components/Layout/index.jsx.

Reviewed by Cursor Bugbot for commit 0adfd5c. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview Jul 4, 2026 2:53pm

Request Review

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a remotely driven announcement banner to the site layout (per PR description: driven by https://nodejs.org/site.json), ensuring it renders across pages using the shared Layout component.

Changes:

  • Import and render RemoteLoadableBanner at the top of the Layout component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/Layout/index.jsx Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@avivkeller avivkeller added this pull request to the merge queue Jul 4, 2026
Merged via the queue into main with commit 1066b5a Jul 4, 2026
7 checks passed
@avivkeller avivkeller deleted the remote-banner branch July 4, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants