http: do not emit socket errors after complete response#64278
Open
Archkon wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
jasnell
approved these changes
Jul 4, 2026
mcollina
added
the
baking-for-lts
Member
|
I fear we need to bake this a bit |
github-actions
Bot
removed
the
request-ci
Collaborator
lpinca
reviewed
Jul 5, 2026
| } | ||
|
|
||
| if (res) { | ||
| socket.destroy(); |
Member
There was a problem hiding this comment.
I think this is redundant as the 'error' event should come from a previous socket.destroy(err) call.
Contributor
Author
There was a problem hiding this comment.
What if a developer uses socket.emit('error')？ This may be rare, but should we do not consider that?
Member
There was a problem hiding this comment.
Stream 'error' events should not be emitted manually. It causes a lot problems. I think it was documented at some point.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64272